diff options
| author | mek <mek@chromium.org> | 2015-01-07 12:33:29 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-07 20:34:30 +0000 |
| commit | 3e31085d2fe944c8fca2d2c06ca416469cc1942e (patch) | |
| tree | f6ca1b4f056aef6e079f5fbc24b4dc692acc37a3 /base/process/launch.h | |
| parent | 205709806da5c07eb640fe256d473f1a64f56e44 (diff) | |
| download | chromium_src-3e31085d2fe944c8fca2d2c06ca416469cc1942e.zip chromium_src-3e31085d2fe944c8fca2d2c06ca416469cc1942e.tar.gz chromium_src-3e31085d2fe944c8fca2d2c06ca416469cc1942e.tar.bz2 | |
Revert of Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess. (patchset #2 id:20001 of https://codereview.chromium.org/831373002/)
Reason for revert:
PrcessTest.CloneWithFlags fails on Linux ChromiumOS Ozone Tests (1):
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/8139/steps/base_unittests/logs/CloneFlags
ProcessTest.CloneFlags (run #1):
[ RUN ] ProcessTest.CloneFlags
../../base/process/process_unittest.cc:241: Failure
Value of: process.IsValid()
Actual: false
Expected: true
[ FAILED ] ProcessTest.CloneFlags (0 ms)
Original issue's description:
> Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess.
>
> ForkWithFlags is a wrapper around the clone syscall that uses the libc
> clone wrapper, and thus updates the libc's pid cache if it has one
> (using sys_clone directly does not update the pid cache, so getpid may
> return an incorrect result in the child). This exposes the ability to
> set clone flags, which is needed to use Linux namespaces.
>
> BUG=312380
>
> Committed: https://crrev.com/e12d6652ece2a3ab72bb05837cfd7f0b0b9ecf3a
> Cr-Commit-Position: refs/heads/master@{#310327}
TBR=jln@chromium.org,mdempsky@chromium.org,thestig@chromium.org,mark@chromium.org,rickyz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=312380
Review URL: https://codereview.chromium.org/842703002
Cr-Commit-Position: refs/heads/master@{#310355}
Diffstat (limited to 'base/process/launch.h')
| -rw-r--r-- | base/process/launch.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/base/process/launch.h b/base/process/launch.h index 8a63b84..0450ddf 100644 --- a/base/process/launch.h +++ b/base/process/launch.h @@ -115,9 +115,6 @@ struct BASE_EXPORT LaunchOptions { #if defined(OS_LINUX) // If non-zero, start the process using clone(), using flags as provided. - // Unlike in clone, clone_flags may not contain a custom termination signal - // that is sent to the parent when the child dies. The termination signal will - // always be set to SIGCHLD. int clone_flags; // By default, child processes will have the PR_SET_NO_NEW_PRIVS bit set. If |