diff options
author | rvargas <rvargas@chromium.org> | 2014-12-04 19:14:54 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-05 03:15:21 +0000 |
commit | 61812774784a9ad2e874e737ebc1b6507da314e2 (patch) | |
tree | 7ed2073300274a2167234a72cf96a9b5b105f328 /base/process/launch.h | |
parent | 0dffffd306e8e21bd027b26e947ec8b5ffcdfa51 (diff) | |
download | chromium_src-61812774784a9ad2e874e737ebc1b6507da314e2.zip chromium_src-61812774784a9ad2e874e737ebc1b6507da314e2.tar.gz chromium_src-61812774784a9ad2e874e737ebc1b6507da314e2.tar.bz2 |
Upgrade the windows specific version of LaunchProcess to avoid raw handles.
This change implies that extensions::LaunchNativeProcess also changes to
return base::Process, and that requires base::EnsureProcessTerminated to
deal with base:Process (as it basically claims ownership of the process).
This CL fixes some leaks all around.
BUG=417532
Committed: https://crrev.com/6b687a5e232c80539772dc3dbe35b98095064c38
Cr-Commit-Position: refs/heads/master@{#306687}
Review URL: https://codereview.chromium.org/759903002
Cr-Commit-Position: refs/heads/master@{#306963}
Diffstat (limited to 'base/process/launch.h')
-rw-r--r-- | base/process/launch.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/base/process/launch.h b/base/process/launch.h index 06abb29..0450ddf 100644 --- a/base/process/launch.h +++ b/base/process/launch.h @@ -22,7 +22,6 @@ #include "base/posix/file_descriptor_shuffle.h" #elif defined(OS_WIN) #include <windows.h> -#include "base/win/scoped_handle.h" #endif namespace base { @@ -174,9 +173,8 @@ BASE_EXPORT bool LaunchProcess(const CommandLine& cmdline, // // Example (including literal quotes) // cmdline = "c:\windows\explorer.exe" -foo "c:\bar\" -BASE_EXPORT bool LaunchProcess(const string16& cmdline, - const LaunchOptions& options, - win::ScopedHandle* process_handle); +BASE_EXPORT Process LaunchProcess(const string16& cmdline, + const LaunchOptions& options); // Launches a process with elevated privileges. This does not behave exactly // like LaunchProcess as it uses ShellExecuteEx instead of CreateProcess to |