diff options
| author | rvargas <rvargas@chromium.org> | 2014-12-03 14:24:06 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-03 22:24:46 +0000 |
| commit | 6b687a5e232c80539772dc3dbe35b98095064c38 (patch) | |
| tree | 152e59d10d89943e7ec0363b8f686b483c9d31be /base/process/launch.h | |
| parent | e77e1c6d3ecf6398fdbd32fd262e6d6d5e00c4bd (diff) | |
| download | chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.zip chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.tar.gz chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.tar.bz2 | |
Upgrade the windows specific version of LaunchProcess to avoid raw handles.
This change implies that extensions::LaunchNativeProcess also changes to
return base::Process, and that requires base::EnsureProcessTerminated to
deal with base:Process (as it basically claims ownership of the process).
This CL fixes some leaks all around.
BUG=417532
Review URL: https://codereview.chromium.org/759903002
Cr-Commit-Position: refs/heads/master@{#306687}
Diffstat (limited to 'base/process/launch.h')
| -rw-r--r-- | base/process/launch.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/base/process/launch.h b/base/process/launch.h index 06abb29..0450ddf 100644 --- a/base/process/launch.h +++ b/base/process/launch.h @@ -22,7 +22,6 @@ #include "base/posix/file_descriptor_shuffle.h" #elif defined(OS_WIN) #include <windows.h> -#include "base/win/scoped_handle.h" #endif namespace base { @@ -174,9 +173,8 @@ BASE_EXPORT bool LaunchProcess(const CommandLine& cmdline, // // Example (including literal quotes) // cmdline = "c:\windows\explorer.exe" -foo "c:\bar\" -BASE_EXPORT bool LaunchProcess(const string16& cmdline, - const LaunchOptions& options, - win::ScopedHandle* process_handle); +BASE_EXPORT Process LaunchProcess(const string16& cmdline, + const LaunchOptions& options); // Launches a process with elevated privileges. This does not behave exactly // like LaunchProcess as it uses ShellExecuteEx instead of CreateProcess to |