summaryrefslogtreecommitdiffstats
path: root/base/process
diff options
context:
space:
mode:
authorthakis <thakis@chromium.org>2015-04-20 09:44:48 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-20 16:44:58 +0000
commit3096daccb8ec31d4e1782720def7918c5ec027a7 (patch)
treef2aa86dce43397106ebe7b5c7036fd2658f62691 /base/process
parent34eb82c8ce5cb9c81814fd1a01dcf6dc5ee2041c (diff)
downloadchromium_src-3096daccb8ec31d4e1782720def7918c5ec027a7.zip
chromium_src-3096daccb8ec31d4e1782720def7918c5ec027a7.tar.gz
chromium_src-3096daccb8ec31d4e1782720def7918c5ec027a7.tar.bz2
Outline Process destructor, fixes a plugin warning on Windows.
..\..\base/process/process.h(44,3) : warning(clang): [chromium-style] Complex destructor has an inline body. ~Process() {} ^ BUG=467287 TBR=dcheng@chromium.org Review URL: https://codereview.chromium.org/1095743003 Cr-Commit-Position: refs/heads/master@{#325860}
Diffstat (limited to 'base/process')
-rw-r--r--base/process/process.h2
-rw-r--r--base/process/process_posix.cc3
-rw-r--r--base/process/process_win.cc3
3 files changed, 7 insertions, 1 deletions
diff --git a/base/process/process.h b/base/process/process.h
index 9b8e775..808baeb 100644
--- a/base/process/process.h
+++ b/base/process/process.h
@@ -41,7 +41,7 @@ class BASE_EXPORT Process {
Process(RValue other);
// The destructor does not terminate the process.
- ~Process() {}
+ ~Process();
// Move operator= for C++03 move emulation of this type.
Process& operator=(RValue other);
diff --git a/base/process/process_posix.cc b/base/process/process_posix.cc
index 389bf76..a7d16f8 100644
--- a/base/process/process_posix.cc
+++ b/base/process/process_posix.cc
@@ -211,6 +211,9 @@ namespace base {
Process::Process(ProcessHandle handle) : process_(handle) {
}
+Process::~Process() {
+}
+
Process::Process(RValue other)
: process_(other.object->process_) {
other.object->Close();
diff --git a/base/process/process_win.cc b/base/process/process_win.cc
index e701ece..0d312a3 100644
--- a/base/process/process_win.cc
+++ b/base/process/process_win.cc
@@ -32,6 +32,9 @@ Process::Process(RValue other)
other.object->Close();
}
+Process::~Process() {
+}
+
Process& Process::operator=(RValue other) {
if (this != other.object) {
process_.Set(other.object->process_.Take());