Check for CloseHandle failures even when not debugging

Bug 524267 was a handle closing failure that only showed up when running
renderer processes under a debugger at startup, so it was not discovered
for a while.

Similarly, bug 520305 is a long-standing base_unittests bug that only
shows up under a debugger.

This change fixes 520305 and checks for many handle closing failures
always so that subsequent bugs of this type will be detected
immediately.

Most of the CloseHandle calls in base are now checked.

This replaces the uncommitted https://codereview.chromium.org/1343873002/

R=grt@chromium.org,rvargas@chromium.org,dalecurtis@chromium.org
BUG=524267,520305

Review URL: https://codereview.chromium.org/1350493002

Cr-Commit-Position: refs/heads/master@{#349333}

1 files changed, 2 insertions, 5 deletions

diff --git a/base/process/kill_win.cc b/base/process/kill_win.cc
index 0da3a26..b35dd63 100644
--- a/base/process/kill_win.cc
+++ b/base/process/kill_win.cc
@@ -159,11 +159,8 @@ bool WaitForProcessesToExit(const FilePath::StringType& executable_name,
     DWORD remaining_wait = static_cast<DWORD>(std::max(
         static_cast<int64>(0),
         wait.InMilliseconds() - (GetTickCount() - start_time)));
-    HANDLE process = OpenProcess(SYNCHRONIZE,
-                                 FALSE,
-                                 entry->th32ProcessID);
-    DWORD wait_result = WaitForSingleObject(process, remaining_wait);
-    CloseHandle(process);
+    Process process(Process::OpenWithAccess(entry->th32ProcessID, SYNCHRONIZE));
+    DWORD wait_result = WaitForSingleObject(process.Handle(), remaining_wait);
     result &= (wait_result == WAIT_OBJECT_0);
   }