diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-06 13:03:47 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-06 13:03:47 +0000 |
| commit | e80bea9a23243ddf8f58c0358df8118159800b53 (patch) | |
| tree | 43f7da3680f9b6045df619184d629e7347ca3c75 /base/process_util.h | |
| parent | 9bf97140e3fb566cda9436a5f2ba33df01f21d6d (diff) | |
| download | chromium_src-e80bea9a23243ddf8f58c0358df8118159800b53.zip chromium_src-e80bea9a23243ddf8f58c0358df8118159800b53.tar.gz chromium_src-e80bea9a23243ddf8f58c0358df8118159800b53.tar.bz2 | |
Make DidProcessCrash a bit more solid and accurate on Windows
I hit the NOTREACHED() inside it while debugging an unrelated problem.
Also, now there is one less special case in this function's contract.
TEST=none
BUG=38048
Review URL: http://codereview.chromium.org/1315009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43706 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util.h')
| -rw-r--r-- | base/process_util.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/base/process_util.h b/base/process_util.h index 705b90b..20f16a7 100644 --- a/base/process_util.h +++ b/base/process_util.h @@ -264,10 +264,6 @@ bool KillProcessById(ProcessId process_id, int exit_code, bool wait); // Get the termination status (exit code) of the process and return true if the // status indicates the process crashed. |child_exited| is set to true iff the // child process has terminated. (|child_exited| may be NULL.) -// -// On Windows, it is an error to call this if the process hasn't terminated -// yet. On POSIX, |child_exited| is set correctly since we detect terminate in -// a different manner on POSIX. bool DidProcessCrash(bool* child_exited, ProcessHandle handle); // Waits for process to exit. In POSIX systems, if the process hasn't been |