diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-25 02:12:09 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-25 02:12:09 +0000 |
| commit | da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0 (patch) | |
| tree | 5e8bfb0503ab08a672054fa34e04ef7cce3d0d2f /base/process_util_linux.cc | |
| parent | 6c293a7baba7aa1d998e2680492246f239a7015d (diff) | |
| download | chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.zip chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.tar.gz chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.tar.bz2 | |
Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util_linux.cc')
| -rw-r--r-- | base/process_util_linux.cc | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/base/process_util_linux.cc b/base/process_util_linux.cc index f9d151b..2f433d9 100644 --- a/base/process_util_linux.cc +++ b/base/process_util_linux.cc @@ -84,7 +84,7 @@ int GetProcessCPU(pid_t pid) { DIR* dir = opendir(path.value().c_str()); if (!dir) { - PLOG(ERROR) << "opendir(" << path.value() << ")"; + DPLOG(ERROR) << "opendir(" << path.value() << ")"; return -1; } @@ -273,7 +273,7 @@ ProcessMetrics* ProcessMetrics::CreateProcessMetrics(ProcessHandle process) { size_t ProcessMetrics::GetPagefileUsage() const { std::vector<std::string> proc_stats; if (!GetProcStats(process_, &proc_stats)) - LOG(WARNING) << "Failed to get process stats."; + DLOG(WARNING) << "Failed to get process stats."; const size_t kVmSize = 22; if (proc_stats.size() > kVmSize) { int vm_size; @@ -287,7 +287,7 @@ size_t ProcessMetrics::GetPagefileUsage() const { size_t ProcessMetrics::GetPeakPagefileUsage() const { std::vector<std::string> proc_stats; if (!GetProcStats(process_, &proc_stats)) - LOG(WARNING) << "Failed to get process stats."; + DLOG(WARNING) << "Failed to get process stats."; const size_t kVmPeak = 21; if (proc_stats.size() > kVmPeak) { int vm_peak; @@ -301,7 +301,7 @@ size_t ProcessMetrics::GetPeakPagefileUsage() const { size_t ProcessMetrics::GetWorkingSetSize() const { std::vector<std::string> proc_stats; if (!GetProcStats(process_, &proc_stats)) - LOG(WARNING) << "Failed to get process stats."; + DLOG(WARNING) << "Failed to get process stats."; const size_t kVmRss = 23; if (proc_stats.size() > kVmRss) { int num_pages; @@ -315,7 +315,7 @@ size_t ProcessMetrics::GetWorkingSetSize() const { size_t ProcessMetrics::GetPeakWorkingSetSize() const { std::vector<std::string> proc_stats; if (!GetProcStats(process_, &proc_stats)) - LOG(WARNING) << "Failed to get process stats."; + DLOG(WARNING) << "Failed to get process stats."; const size_t kVmHwm = 23; if (proc_stats.size() > kVmHwm) { int num_pages; @@ -576,14 +576,14 @@ bool GetSystemMemoryInfo(SystemMemoryInfoKB* meminfo) { FilePath meminfo_file("/proc/meminfo"); std::string meminfo_data; if (!file_util::ReadFileToString(meminfo_file, &meminfo_data)) { - LOG(WARNING) << "Failed to open /proc/meminfo."; + DLOG(WARNING) << "Failed to open /proc/meminfo."; return false; } std::vector<std::string> meminfo_fields; SplitStringAlongWhitespace(meminfo_data, &meminfo_fields); if (meminfo_fields.size() < kMemCachedIndex) { - LOG(WARNING) << "Failed to parse /proc/meminfo. Only found " << + DLOG(WARNING) << "Failed to parse /proc/meminfo. Only found " << meminfo_fields.size() << " fields."; return false; } @@ -752,7 +752,8 @@ bool AdjustOOMScore(ProcessId process, int score) { FilePath oom_file = oom_path.AppendASCII("oom_score_adj"); if (file_util::PathExists(oom_file)) { std::string score_str = base::IntToString(score); - VLOG(1) << "Adjusting oom_score_adj of " << process << " to " << score_str; + DVLOG(1) << "Adjusting oom_score_adj of " << process << " to " + << score_str; int score_len = static_cast<int>(score_str.length()); return (score_len == file_util::WriteFile(oom_file, score_str.c_str(), @@ -765,7 +766,7 @@ bool AdjustOOMScore(ProcessId process, int score) { if (file_util::PathExists(oom_file)) { std::string score_str = base::IntToString( score * kMaxOldOomScore / kMaxOomScore); - VLOG(1) << "Adjusting oom_adj of " << process << " to " << score_str; + DVLOG(1) << "Adjusting oom_adj of " << process << " to " << score_str; int score_len = static_cast<int>(score_str.length()); return (score_len == file_util::WriteFile(oom_file, score_str.c_str(), |