summaryrefslogtreecommitdiffstats
path: root/base/strings/string_split.cc
diff options
context:
space:
mode:
authordanakj <danakj@chromium.org>2015-03-09 15:27:25 -0700
committerCommit bot <commit-bot@chromium.org>2015-03-09 22:28:34 +0000
commit94219a212c616eac1914ca851c55256c4bbd9e36 (patch)
treeb9721bd6f2d10f117355fdfa1a0391262b745628 /base/strings/string_split.cc
parent6be122fb693fe8f2a5b150a12bddd5c85160b7a6 (diff)
downloadchromium_src-94219a212c616eac1914ca851c55256c4bbd9e36.zip
chromium_src-94219a212c616eac1914ca851c55256c4bbd9e36.tar.gz
chromium_src-94219a212c616eac1914ca851c55256c4bbd9e36.tar.bz2
base: Use more specific CHECK macros for comparisons.
Prefer DCHECK_EQ(a, b) over DCHECK(a == b) when possible as this provides more data on a failure. Similar for other operators such as >=, <, !=, etc. This also applies to CHECK, EXPECT, and ASSERT macros. R=Nico BUG=464816 Review URL: https://codereview.chromium.org/985723003 Cr-Commit-Position: refs/heads/master@{#319751}
Diffstat (limited to 'base/strings/string_split.cc')
-rw-r--r--base/strings/string_split.cc8
1 files changed, 4 insertions, 4 deletions
diff --git a/base/strings/string_split.cc b/base/strings/string_split.cc
index 7ef4760..692f300 100644
--- a/base/strings/string_split.cc
+++ b/base/strings/string_split.cc
@@ -138,9 +138,9 @@ void SplitString(const std::string& str,
char c,
std::vector<std::string>* r) {
#if CHAR_MIN < 0
- DCHECK(c >= 0);
+ DCHECK_GE(c, 0);
#endif
- DCHECK(c < 0x7F);
+ DCHECK_LT(c, 0x7F);
SplitStringT(str, c, true, r);
}
@@ -195,9 +195,9 @@ void SplitStringDontTrim(const std::string& str,
std::vector<std::string>* r) {
DCHECK(IsStringUTF8(str));
#if CHAR_MIN < 0
- DCHECK(c >= 0);
+ DCHECK_GE(c, 0);
#endif
- DCHECK(c < 0x7F);
+ DCHECK_LT(c, 0x7F);
SplitStringT(str, c, false, r);
}