diff options
author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 10:52:11 +0000 |
---|---|---|
committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 10:52:11 +0000 |
commit | f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5 (patch) | |
tree | 1d7a6fc34e066dcbf9d2bc01af2244f72cbd78a7 /base/synchronization | |
parent | d443be6fdfe17ca4f3ff1843ded362ff0cd01096 (diff) | |
download | chromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.zip chromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.tar.gz chromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.tar.bz2 |
Add missing, and remove unnecessary, 'explicit' from constructors. (base/)
The style guide says that constructors which can be called with one
argument should be explicit.
For constructors which cannot be called with exactly one argument,
there is no reason to mark them explicit.
BUG=163357
Review URL: https://chromiumcodereview.appspot.com/11779022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176881 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/synchronization')
-rw-r--r-- | base/synchronization/condition_variable_unittest.cc | 2 | ||||
-rw-r--r-- | base/synchronization/lock_unittest.cc | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/base/synchronization/condition_variable_unittest.cc b/base/synchronization/condition_variable_unittest.cc index 4162d4f..a6426cf 100644 --- a/base/synchronization/condition_variable_unittest.cc +++ b/base/synchronization/condition_variable_unittest.cc @@ -35,7 +35,7 @@ class ConditionVariableTest : public PlatformTest { const TimeDelta kSixtyMs; const TimeDelta kOneHundredMs; - explicit ConditionVariableTest() + ConditionVariableTest() : kZeroMs(TimeDelta::FromMilliseconds(0)), kTenMs(TimeDelta::FromMilliseconds(10)), kThirtyMs(TimeDelta::FromMilliseconds(30)), diff --git a/base/synchronization/lock_unittest.cc b/base/synchronization/lock_unittest.cc index a048f85..e87571d 100644 --- a/base/synchronization/lock_unittest.cc +++ b/base/synchronization/lock_unittest.cc @@ -16,7 +16,7 @@ namespace base { class BasicLockTestThread : public PlatformThread::Delegate { public: - BasicLockTestThread(Lock* lock) : lock_(lock), acquired_(0) {} + explicit BasicLockTestThread(Lock* lock) : lock_(lock), acquired_(0) {} virtual void ThreadMain() OVERRIDE { for (int i = 0; i < 10; i++) { @@ -91,7 +91,7 @@ TEST(LockTest, Basic) { class TryLockTestThread : public PlatformThread::Delegate { public: - TryLockTestThread(Lock* lock) : lock_(lock), got_lock_(false) {} + explicit TryLockTestThread(Lock* lock) : lock_(lock), got_lock_(false) {} virtual void ThreadMain() OVERRIDE { got_lock_ = lock_->Try(); |