summaryrefslogtreecommitdiffstats
path: root/base/sys_info_chromeos.cc
diff options
context:
space:
mode:
authorrkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-09 01:35:07 +0000
committerrkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-09 01:35:07 +0000
commita25a282fec053eaab36afddba1f4d3c65e58ced1 (patch)
tree0a011e0013c9a5c65396d2fb84f58182b86e99bb /base/sys_info_chromeos.cc
parentc30cf4b1575efd31a34bd3f82a52e729e0e90183 (diff)
downloadchromium_src-a25a282fec053eaab36afddba1f4d3c65e58ced1.zip
chromium_src-a25a282fec053eaab36afddba1f4d3c65e58ced1.tar.gz
chromium_src-a25a282fec053eaab36afddba1f4d3c65e58ced1.tar.bz2
Fix for system version unit tests in cros.
BUG=chromium-os:15789 TEST=Ran try servers to make sure the unit test is not failing anymore, plus viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug TBR=rkc@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88470 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/sys_info_chromeos.cc')
-rw-r--r--base/sys_info_chromeos.cc11
1 files changed, 7 insertions, 4 deletions
diff --git a/base/sys_info_chromeos.cc b/base/sys_info_chromeos.cc
index cd17c18..f724f99 100644
--- a/base/sys_info_chromeos.cc
+++ b/base/sys_info_chromeos.cc
@@ -94,17 +94,20 @@ void SysInfo::ParseLsbRelease(const std::string& lsb_release,
size_t length = lsb_release.find_first_of('\n', start_index) - start_index;
std::string version = lsb_release.substr(start_index, length);
StringTokenizer tokenizer(version, ".");
- for (int i = 0; i < 3 && tokenizer.GetNext(); i++) {
- if (0 == i) {
+ // TODO(rkc): Ignore the 0. here; fix this once we move Chrome OS version
+ // numbers from the 0.xx.yyy.zz format to the xx.yyy.zz format.
+ // Refer to http://code.google.com/p/chromium-os/issues/detail?id=15789
+ for (int i = 0; i < 4 && tokenizer.GetNext(); i++) {
+ if (1 == i) {
StringToInt(tokenizer.token_begin(),
tokenizer.token_end(),
major_version);
*minor_version = *bugfix_version = 0;
- } else if (1 == i) {
+ } else if (2 == i) {
StringToInt(tokenizer.token_begin(),
tokenizer.token_end(),
minor_version);
- } else { // 2 == i
+ } else { // 3 == i
StringToInt(tokenizer.token_begin(),
tokenizer.token_end(),
bugfix_version);