diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-08 21:01:26 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-08 21:01:26 +0000 |
| commit | f0e6b93b7d7c615a9b19cf79283b49dd3303b87e (patch) | |
| tree | f46f4943ffac86bbde573d6e119792fa33cbb11c /base/test/multiprocess_test_android.cc | |
| parent | 43ebe9ea4f1467868b63f1b0688c8f8dff73c032 (diff) | |
| download | chromium_src-f0e6b93b7d7c615a9b19cf79283b49dd3303b87e.zip chromium_src-f0e6b93b7d7c615a9b19cf79283b49dd3303b87e.tar.gz chromium_src-f0e6b93b7d7c615a9b19cf79283b49dd3303b87e.tar.bz2 | |
Add multiprocess test helper functions.
Don't force people who want to write multiprocess tests to derive their
test fixture from MultiProcessTest.
TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/189373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255796 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test/multiprocess_test_android.cc')
| -rw-r--r-- | base/test/multiprocess_test_android.cc | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/base/test/multiprocess_test_android.cc b/base/test/multiprocess_test_android.cc index c518bb4..8a85cdf 100644 --- a/base/test/multiprocess_test_android.cc +++ b/base/test/multiprocess_test_android.cc @@ -15,14 +15,15 @@ namespace base { // A very basic implementation for Android. On Android tests can run in an APK // and we don't have an executable to exec*. This implementation does the bare // minimum to execute the method specified by procname (in the child process). +// - |base_command_line| is ignored. // - All options except |fds_to_remap| are ignored. // - |debug_on_start| is ignored. -ProcessHandle MultiProcessTest::SpawnChildWithOptions( - const std::string& procname, - const LaunchOptions& options, - bool debug_on_start) { - // TODO(vtl): The FD-remapping done below is wrong in the presence of cycles - // (e.g., fd1 -> fd2, fd2 -> fd1). crbug.com/326576 +ProcessHandle SpawnMultiProcessTestChild(const std::string& procname, + const CommandLine& base_command_line, + const LaunchOptions& options, + bool debug_on_start) { + // TODO(viettrungluu): The FD-remapping done below is wrong in the presence of + // cycles (e.g., fd1 -> fd2, fd2 -> fd1). crbug.com/326576 FileHandleMappingVector empty; const FileHandleMappingVector* fds_to_remap = options.fds_to_remap ? options.fds_to_remap : ∅ |