diff options
author | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-18 08:11:48 +0000 |
---|---|---|
committer | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-18 08:11:48 +0000 |
commit | 78bed5cc602b080f5ad67a959c43d47f4c95377a (patch) | |
tree | 53c4b214ad80a12318559802147d8ef6d52da6cd /base/test/sequenced_worker_pool_owner.cc | |
parent | 7b289a4831e91d40e53a34e97562c1a0aac9a810 (diff) | |
download | chromium_src-78bed5cc602b080f5ad67a959c43d47f4c95377a.zip chromium_src-78bed5cc602b080f5ad67a959c43d47f4c95377a.tar.gz chromium_src-78bed5cc602b080f5ad67a959c43d47f4c95377a.tar.bz2 |
[sync] Clean up SyncSetupHandler: Detach sign in from sync setup
SyncSetupHandler is a class used for sync setup, and sometimes needs to
initiate a gaia sign in. Today, it does so via SigninTracker, and keeps
track of the sign in progress while displaying a spinner or a grayed out
"in progress" sign in button. This is unnecessary, since other classes
that initiate sync setup respond only after sign in is complete, instead
of keeping track of an ongoing sign in.
This patch does multiple things:
1) Removes the use of SigninTracker from SyncSetupHandler, and updates
the logic to close the sync setup wizard when control is handed off
to the gaia sign in tab.
2) Updates OneClickSigninHelper to automatically close the gaia sign in
tab before handing back control to SyncSetupHandler, in cases when
the settings page initiates a gaia re-auth.
3) Miscellaneous clean up related to the above behavior changes.
Note: This bug takes care of item #2 in bug 241353.
BUG=241353, 259150, 261317, 261367. 92948
TEST=Initiate sync setup or re-auth via the settings page. The setup dialog must be closed during sign in, and be reopened after sign in.
Review URL: https://chromiumcodereview.appspot.com/18698004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212279 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test/sequenced_worker_pool_owner.cc')
0 files changed, 0 insertions, 0 deletions