diff options
| author | cjhopman <cjhopman@chromium.org> | 2014-10-27 10:11:18 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-27 17:11:34 +0000 |
| commit | 09981a9eb8bff00e2644f3174e5651b5734eed9a (patch) | |
| tree | 95f1e38463a94a67b65cb937e64add40bda228b2 /base/third_party | |
| parent | 68c65a48b958c1a5e029cece19ef5eb01ab99fff (diff) | |
| download | chromium_src-09981a9eb8bff00e2644f3174e5651b5734eed9a.zip chromium_src-09981a9eb8bff00e2644f3174e5651b5734eed9a.tar.gz chromium_src-09981a9eb8bff00e2644f3174e5651b5734eed9a.tar.bz2 | |
GN: Fix Android component build
This change makes all libraries in the Android component build link
successfully (including fixing and enabling libchrome_shell). This also makes
all the libraries link in a component build for Linux, but without bot coverage
for that platform it'll surely regress.
This is almost entirely just fixing some missing/incorrect dependencies and
adding missing source files for Android.
Some targets were depending on an internal source_set/static_library when they
should have been (or already were) depending on the corresponding component. In
these cases, I added some visibility restrictions to those internal targets to
try to prevent those types of dependencies from coming back.
BUG=359249
Review URL: https://codereview.chromium.org/666813002
Cr-Commit-Position: refs/heads/master@{#301386}
Diffstat (limited to 'base/third_party')
| -rw-r--r-- | base/third_party/nspr/BUILD.gn | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/third_party/nspr/BUILD.gn b/base/third_party/nspr/BUILD.gn index ddbcbc1..516ca1f 100644 --- a/base/third_party/nspr/BUILD.gn +++ b/base/third_party/nspr/BUILD.gn @@ -3,7 +3,7 @@ # found in the LICENSE file. source_set("nspr") { - visibility = [ "//base/*" ] + visibility = [ "//base" ] sources = [ "prtime.cc", "prtime.h", |