summaryrefslogtreecommitdiffstats
path: root/base/threading
diff options
context:
space:
mode:
authorrsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-09-25 19:31:43 +0000
committerrsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-09-25 19:31:43 +0000
commit018ab8789d64f23ab821151f1d670a6ef54fa5f3 (patch)
tree22d9eb6ba034c60b63553713ad2ca4ac35dd431a /base/threading
parent8ce64609179a7a98824d2bef2630e7ccefc46bf0 (diff)
downloadchromium_src-018ab8789d64f23ab821151f1d670a6ef54fa5f3.zip
chromium_src-018ab8789d64f23ab821151f1d670a6ef54fa5f3.tar.gz
chromium_src-018ab8789d64f23ab821151f1d670a6ef54fa5f3.tar.bz2
Revert 222826 "Copy the thread name to the stack for debugging p..."
> Copy the thread name to the stack for debugging purposes. > > The this ptr in Thread is getting smashed after the MessageLoop ends, which > leaves very little to go on. This is kind of a stab in the dark, but hopefully > it makes something bleed in a general direction. > > BUG=274705 > TEST=Minidumps contain 47 bytes of thread name data way high on the stack. > R=mark@chromium.org > > Review URL: https://codereview.chromium.org/23606030 TBR=rsesek@chromium.org Review URL: https://codereview.chromium.org/24508003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225228 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/threading')
-rw-r--r--base/threading/thread.cc18
1 files changed, 0 insertions, 18 deletions
diff --git a/base/threading/thread.cc b/base/threading/thread.cc
index f033775..aca4ddb 100644
--- a/base/threading/thread.cc
+++ b/base/threading/thread.cc
@@ -5,7 +5,6 @@
#include "base/threading/thread.h"
#include "base/bind.h"
-#include "base/debug/alias.h"
#include "base/lazy_instance.h"
#include "base/third_party/dynamic_annotations/dynamic_annotations.h"
#include "base/threading/thread_id_name_manager.h"
@@ -173,19 +172,6 @@ bool Thread::GetThreadWasQuitProperly() {
void Thread::ThreadMain() {
{
-#if defined(OS_MACOSX)
- // Store the thread name on the stack to debug <http://crbug.com/274705>.
- // End with a byte sequence of <EOT><BEL><NUL> to make it easier to grep in
- // the minidump stack dump.
- const size_t kThreadNameSize = 50;
- char thread_name[kThreadNameSize];
- strncpy(thread_name, name_.c_str(), kThreadNameSize);
- thread_name[kThreadNameSize - 1] = '\0';
- thread_name[kThreadNameSize - 2] = '\7';
- thread_name[kThreadNameSize - 3] = '\3';
- base::debug::Alias(thread_name);
-#endif
-
// The message loop for this thread.
// Allocated on the heap to centralize any leak reports at this line.
scoped_ptr<MessageLoop> message_loop(
@@ -231,10 +217,6 @@ void Thread::ThreadMain() {
// We can't receive messages anymore.
message_loop_ = NULL;
-
-#if defined(OS_MACOSX)
- base::debug::Alias(thread_name);
-#endif
}
}