diff options
author | vmpstr <vmpstr@chromium.org> | 2016-03-21 13:28:47 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-21 20:30:28 +0000 |
commit | a34d11324e0767acd94d8754e3a117e072492cf4 (patch) | |
tree | ac723766c79172c76341b45aab9c1914169b4466 /base/threading | |
parent | 8a2f463d3726f944f5ec279664b25118fd3ccf3c (diff) | |
download | chromium_src-a34d11324e0767acd94d8754e3a117e072492cf4.zip chromium_src-a34d11324e0767acd94d8754e3a117e072492cf4.tar.gz chromium_src-a34d11324e0767acd94d8754e3a117e072492cf4.tar.bz2 |
Add RetainedRef uses where needed.
This patch adds RetainedRef uses where they are required. These
changes will be required when we remove automatic unwrapping of
scoped_refptrs in Bind.
Please see the bug for more context.
R=tzik@chromium.org, thakis@chromium.org, danakj@chromium.org
BUG=589048
Review URL: https://codereview.chromium.org/1815363002
Cr-Commit-Position: refs/heads/master@{#382371}
Diffstat (limited to 'base/threading')
-rw-r--r-- | base/threading/sequenced_worker_pool_unittest.cc | 32 |
1 files changed, 17 insertions, 15 deletions
diff --git a/base/threading/sequenced_worker_pool_unittest.cc b/base/threading/sequenced_worker_pool_unittest.cc index 2855b9f..a0be607 100644 --- a/base/threading/sequenced_worker_pool_unittest.cc +++ b/base/threading/sequenced_worker_pool_unittest.cc @@ -566,9 +566,8 @@ TEST_F(SequencedWorkerPoolTest, AllowsAfterShutdown) { const int kNumQueuedTasks = static_cast<int>(kNumWorkerThreads); for (int i = 0; i < kNumQueuedTasks; ++i) { EXPECT_TRUE(pool()->PostWorkerTaskWithShutdownBehavior( - FROM_HERE, - base::Bind(&TestTracker::PostAdditionalTasks, tracker(), i, pool(), - false), + FROM_HERE, base::Bind(&TestTracker::PostAdditionalTasks, tracker(), i, + base::RetainedRef(pool()), false), SequencedWorkerPool::BLOCK_SHUTDOWN)); } @@ -808,15 +807,19 @@ TEST_F(SequencedWorkerPoolTest, IsRunningOnCurrentThread) { unsequenced_token)); pool()->PostSequencedWorkerTask( - token1, FROM_HERE, base::Bind(&IsRunningOnCurrentThreadTask, token1, - token2, pool(), unused_pool_owner.pool())); + token1, FROM_HERE, + base::Bind(&IsRunningOnCurrentThreadTask, token1, token2, + base::RetainedRef(pool()), + base::RetainedRef(unused_pool_owner.pool()))); pool()->PostSequencedWorkerTask( token2, FROM_HERE, base::Bind(&IsRunningOnCurrentThreadTask, token2, unsequenced_token, - pool(), unused_pool_owner.pool())); + base::RetainedRef(pool()), + base::RetainedRef(unused_pool_owner.pool()))); pool()->PostWorkerTask( FROM_HERE, base::Bind(&IsRunningOnCurrentThreadTask, unsequenced_token, - token1, pool(), unused_pool_owner.pool())); + token1, base::RetainedRef(pool()), + base::RetainedRef(unused_pool_owner.pool()))); } // Checks that tasks are destroyed in the right context during shutdown. If a @@ -873,9 +876,8 @@ TEST_F(SequencedWorkerPoolTest, FlushForTesting) { base::Bind(&TestTracker::FastTask, tracker(), 0)); } pool()->PostWorkerTask( - FROM_HERE, - base::Bind(&TestTracker::PostAdditionalTasks, tracker(), 0, pool(), - true)); + FROM_HERE, base::Bind(&TestTracker::PostAdditionalTasks, tracker(), 0, + base::RetainedRef(pool()), true)); // We expect all except the delayed task to have been run. We verify all // closures have been deleted by looking at the refcount of the @@ -949,10 +951,10 @@ void VerifyCurrentSequencedTaskRunnerForUnsequencedTask( // VerifyCurrentSequencedTaskRunner() above for why the check is implemented // this way. const bool expected_equal = true; - task_runner->PostTask( - FROM_HERE, - Bind(&VerifySequencedTaskRunnerRunsOnCurrentThread, - std::move(expected_task_runner), expected_equal, callback)); + task_runner->PostTask(FROM_HERE, + Bind(&VerifySequencedTaskRunnerRunsOnCurrentThread, + RetainedRef(std::move(expected_task_runner)), + expected_equal, callback)); } TEST_F(SequencedWorkerPoolTest, GetSequencedTaskRunnerForCurrentThread) { @@ -986,7 +988,7 @@ TEST_F(SequencedWorkerPoolTest, GetSequencedTaskRunnerForCurrentThread) { pool()->PostWorkerTask( FROM_HERE, Bind(&VerifyCurrentSequencedTaskRunnerForUnsequencedTask, - pool(), signal)); + RetainedRef(pool()), signal)); event.Wait(); } |