diff options
author | fdoray <fdoray@chromium.org> | 2015-11-11 17:12:32 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-11-12 01:13:07 +0000 |
commit | 28787424acfc81f458824812a35c67d461b84035 (patch) | |
tree | 4397eac47c27644a7f12e9b773468488f1ca61a6 /base/trace_event | |
parent | c441f78fcb48ef54a880e32fc2b43996958d3eb9 (diff) | |
download | chromium_src-28787424acfc81f458824812a35c67d461b84035.zip chromium_src-28787424acfc81f458824812a35c67d461b84035.tar.gz chromium_src-28787424acfc81f458824812a35c67d461b84035.tar.bz2 |
Add ProcessMetrics::CreateCurrentProcessMetrics() method.
Code that creates a ProcessMetrics object can be confusing because
ProcessMetrics::CreateProcessMetrics() has a different signature on Mac.
The extra Mac parameter isn't required when creating a ProcessMetrics
object for the current process (which is a common thing to do).
To allow simplification of code that creates a ProcessMetrics object
for the current process, this CL introduces a new
ProcessMetrics::CreateCurrentProcessMetrics() method, which has the
same signature on all platforms.
BUG=553266
Review URL: https://codereview.chromium.org/1433603004
Cr-Commit-Position: refs/heads/master@{#359199}
Diffstat (limited to 'base/trace_event')
-rw-r--r-- | base/trace_event/process_memory_totals_dump_provider.cc | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/base/trace_event/process_memory_totals_dump_provider.cc b/base/trace_event/process_memory_totals_dump_provider.cc index c057deb..83015f8 100644 --- a/base/trace_event/process_memory_totals_dump_provider.cc +++ b/base/trace_event/process_memory_totals_dump_provider.cc @@ -25,17 +25,6 @@ namespace trace_event { // static uint64 ProcessMemoryTotalsDumpProvider::rss_bytes_for_testing = 0; -namespace { - -ProcessMetrics* CreateProcessMetricsForCurrentProcess() { -#if !defined(OS_MACOSX) || defined(OS_IOS) - return ProcessMetrics::CreateProcessMetrics(GetCurrentProcessHandle()); -#else - return ProcessMetrics::CreateProcessMetrics(GetCurrentProcessHandle(), NULL); -#endif -} -} // namespace - // static ProcessMemoryTotalsDumpProvider* ProcessMemoryTotalsDumpProvider::GetInstance() { @@ -45,8 +34,7 @@ ProcessMemoryTotalsDumpProvider::GetInstance() { } ProcessMemoryTotalsDumpProvider::ProcessMemoryTotalsDumpProvider() - : process_metrics_(CreateProcessMetricsForCurrentProcess()) { -} + : process_metrics_(ProcessMetrics::CreateCurrentProcessMetrics()) {} ProcessMemoryTotalsDumpProvider::~ProcessMemoryTotalsDumpProvider() { } |