diff options
| author | danakj <danakj@chromium.org> | 2015-03-09 15:27:25 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-09 22:28:34 +0000 |
| commit | 94219a212c616eac1914ca851c55256c4bbd9e36 (patch) | |
| tree | b9721bd6f2d10f117355fdfa1a0391262b745628 /base/trace_event | |
| parent | 6be122fb693fe8f2a5b150a12bddd5c85160b7a6 (diff) | |
| download | chromium_src-94219a212c616eac1914ca851c55256c4bbd9e36.zip chromium_src-94219a212c616eac1914ca851c55256c4bbd9e36.tar.gz chromium_src-94219a212c616eac1914ca851c55256c4bbd9e36.tar.bz2 | |
base: Use more specific CHECK macros for comparisons.
Prefer DCHECK_EQ(a, b) over DCHECK(a == b) when possible as this
provides more data on a failure. Similar for other operators such as
>=, <, !=, etc.
This also applies to CHECK, EXPECT, and ASSERT macros.
R=Nico
BUG=464816
Review URL: https://codereview.chromium.org/985723003
Cr-Commit-Position: refs/heads/master@{#319751}
Diffstat (limited to 'base/trace_event')
| -rw-r--r-- | base/trace_event/process_memory_maps_dump_provider.cc | 2 | ||||
| -rw-r--r-- | base/trace_event/trace_event_impl.cc | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/base/trace_event/process_memory_maps_dump_provider.cc b/base/trace_event/process_memory_maps_dump_provider.cc index 93feded..fbe0eb1 100644 --- a/base/trace_event/process_memory_maps_dump_provider.cc +++ b/base/trace_event/process_memory_maps_dump_provider.cc @@ -47,7 +47,7 @@ bool ParseSmapsHeader(std::istream* smaps, region->protection_flags = 0; *smaps >> protection_flags; - CHECK(4UL == protection_flags.size()); + CHECK_EQ(4UL, protection_flags.size()); if (protection_flags[0] == 'r') { region->protection_flags |= ProcessMemoryMaps::VMRegion::kProtectionFlagsRead; diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc index 34bbb28..bd0b57d 100644 --- a/base/trace_event/trace_event_impl.cc +++ b/base/trace_event/trace_event_impl.cc @@ -624,7 +624,7 @@ void TraceEvent::Reset() { void TraceEvent::UpdateDuration(const TimeTicks& now, const TimeTicks& thread_now) { - DCHECK(duration_.ToInternalValue() == -1); + DCHECK_EQ(duration_.ToInternalValue(), -1); duration_ = now - timestamp_; thread_duration_ = thread_now - thread_timestamp_; } @@ -2588,7 +2588,7 @@ namespace trace_event_internal { ScopedTraceBinaryEfficient::ScopedTraceBinaryEfficient( const char* category_group, const char* name) { // The single atom works because for now the category_group can only be "gpu". - DCHECK(strcmp(category_group, "gpu") == 0); + DCHECK_EQ(strcmp(category_group, "gpu"), 0); static TRACE_EVENT_API_ATOMIC_WORD atomic = 0; INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO_CUSTOM_VARIABLES( category_group, atomic, category_group_enabled_); |