base: Add AsBinary() function to Value API.

This function should simplify some constructions.

Instead of:

if (!value->IsType(Value::TYPE_BINARY))
  return false;
  BinaryValue* binary_value = static_cast<BinaryValue*>(value);

You can do:

BinaryValue* binary_value = value->AsBinary();
if (!binary_value)
  return false;

BUG=None
TEST=base_unittests --gtest_filter=Values*

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7748017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98266 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 7 deletions

diff --git a/base/values_unittest.cc b/base/values_unittest.cc
index c8d3e3c..0ca19d9 100644
--- a/base/values_unittest.cc
+++ b/base/values_unittest.cc
@@ -416,14 +416,13 @@ TEST(ValuesTest, DeepCopy) {
   ASSERT_TRUE(copy_dict->Get("binary", &copy_binary));
   ASSERT_TRUE(copy_binary);
   ASSERT_NE(copy_binary, original_binary);
-  ASSERT_TRUE(copy_binary->IsType(Value::TYPE_BINARY));
-  ASSERT_NE(original_binary->GetBuffer(),
-    static_cast<BinaryValue*>(copy_binary)->GetBuffer());
-  ASSERT_EQ(original_binary->GetSize(),
-    static_cast<BinaryValue*>(copy_binary)->GetSize());
+  BinaryValue* binary_value = copy_binary->AsBinary();
+  ASSERT_TRUE(binary_value);
+  ASSERT_NE(original_binary->GetBuffer(), binary_value->GetBuffer());
+  ASSERT_EQ(original_binary->GetSize(), binary_value->GetSize());
   ASSERT_EQ(0, memcmp(original_binary->GetBuffer(),
-               static_cast<BinaryValue*>(copy_binary)->GetBuffer(),
-               original_binary->GetSize()));
+                      binary_value->GetBuffer(),
+                      original_binary->GetSize()));
 
   Value* copy_value = NULL;
   ASSERT_TRUE(copy_dict->Get("list", &copy_value));