diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-13 17:34:31 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-13 17:34:31 +0000 |
| commit | 4fc3c56432cde7d5c938cb75bdfbabd75d9ec755 (patch) | |
| tree | c75bebaa6ad73888b12e93a24c1880ece01dde96 /base/values_unittest.cc | |
| parent | 9978b8f0cbac1cd176a6ecac457eb9dacd3ad0f0 (diff) | |
| download | chromium_src-4fc3c56432cde7d5c938cb75bdfbabd75d9ec755.zip chromium_src-4fc3c56432cde7d5c938cb75bdfbabd75d9ec755.tar.gz chromium_src-4fc3c56432cde7d5c938cb75bdfbabd75d9ec755.tar.bz2 | |
base: Fix the TODO in ListValue::Remove().
Change the return type of Remove() to bool, and add a size_t output parameter.
BUG=None
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7618021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96702 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/values_unittest.cc')
| -rw-r--r-- | base/values_unittest.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/base/values_unittest.cc b/base/values_unittest.cc index b5bcbe1..553e8e1 100644 --- a/base/values_unittest.cc +++ b/base/values_unittest.cc @@ -236,7 +236,9 @@ TEST(ValuesTest, ListRemoval) { DeletionTestValue* value = new DeletionTestValue(&deletion_flag); list.Append(value); EXPECT_FALSE(deletion_flag); - EXPECT_EQ(0, list.Remove(*value)); + size_t index = 0; + list.Remove(*value, &index); + EXPECT_EQ(0U, index); EXPECT_TRUE(deletion_flag); EXPECT_EQ(0U, list.GetSize()); } |