diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 19:59:11 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 19:59:11 +0000 |
| commit | 6832cbe85f9d342d84d0ddbb2d017496f7649e5d (patch) | |
| tree | 5df5727a7a04ecf425f349bf4c06c71d0c6c7c57 /base/values_unittest.cc | |
| parent | e1245358ad4226525d7c1e0da06356ebe5715aa7 (diff) | |
| download | chromium_src-6832cbe85f9d342d84d0ddbb2d017496f7649e5d.zip chromium_src-6832cbe85f9d342d84d0ddbb2d017496f7649e5d.tar.gz chromium_src-6832cbe85f9d342d84d0ddbb2d017496f7649e5d.tar.bz2 | |
Fix a memory leak when calling the one-arg form of ListValue::Remove().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/434108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33314 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/values_unittest.cc')
| -rw-r--r-- | base/values_unittest.cc | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/base/values_unittest.cc b/base/values_unittest.cc index 0182d76..5835e2b 100644 --- a/base/values_unittest.cc +++ b/base/values_unittest.cc @@ -224,6 +224,16 @@ TEST(ValuesTest, ListRemoval) { EXPECT_TRUE(deletion_flag); EXPECT_EQ(0U, list.GetSize()); } + + { + ListValue list; + DeletionTestValue* value = new DeletionTestValue(&deletion_flag); + list.Append(value); + EXPECT_FALSE(deletion_flag); + EXPECT_EQ(0, list.Remove(*value)); + EXPECT_TRUE(deletion_flag); + EXPECT_EQ(0U, list.GetSize()); + } } TEST(ValuesTest, DictionaryDeletion) { |