diff options
| author | scottmg@chromium.org <scottmg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-15 23:45:17 +0000 |
|---|---|---|
| committer | scottmg@chromium.org <scottmg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-15 23:45:17 +0000 |
| commit | 301562dde5069c65010ab9b772d7cc0a00e3d3c3 (patch) | |
| tree | 0497e7c81623289700eb7ea31049b2c0fca13f8e /base/win | |
| parent | ed877a5feb5e7709c896c9edc0bc48420feaa098 (diff) | |
| download | chromium_src-301562dde5069c65010ab9b772d7cc0a00e3d3c3.zip chromium_src-301562dde5069c65010ab9b772d7cc0a00e3d3c3.tar.gz chromium_src-301562dde5069c65010ab9b772d7cc0a00e3d3c3.tar.bz2 | |
better error messaging for un-updated vs2012
another attempt at making it more clear what's going on for random bots.
if it's out of date, the compiler will output something like this now:
Relevant defines:
#define _M_IX86 600
#define _MSC_FULL_VER 170051106
Visual Studio 2012 x86 must be updated to at least Update 1
d:\src\cr\src\base\win\win_util.cc(353) : fatal error C1004: unexpected end-of-file found
R=cpu@chromium.org
Review URL: https://codereview.chromium.org/12780006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188509 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/win')
| -rw-r--r-- | base/win/win_util.cc | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/base/win/win_util.cc b/base/win/win_util.cc index 774b11d..acdc907 100644 --- a/base/win/win_util.cc +++ b/base/win/win_util.cc @@ -334,6 +334,22 @@ bool DismissVirtualKeyboard() { // There are optimizer bugs in x86 VS2012 pre-Update 1. #if _MSC_VER == 1700 && defined _M_IX86 && _MSC_FULL_VER < 170051106 + +#pragma message("Relevant defines:") +#define __STR2__(x) #x +#define __STR1__(x) __STR2__(x) +#define __PPOUT__(x) "#define " #x " " __STR1__(x) +#if defined(_M_IX86) + #pragma message(__PPOUT__(_M_IX86)) +#endif +#if defined(_M_X64) + #pragma message(__PPOUT__(_M_X64)) +#endif +#if defined(_MSC_FULL_VER) + #pragma message(__PPOUT__(_MSC_FULL_VER)) +#endif + +#pragma message("Visual Studio 2012 x86 must be updated to at least Update 1") #error Must install Update 1 to Visual Studio 2012. #endif |