diff options
| author | davidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-02 01:57:31 +0000 |
|---|---|---|
| committer | davidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-02 01:57:31 +0000 |
| commit | 1283330e588bf1d5e73e7c2533af4c85e7cdc5a2 (patch) | |
| tree | 7936291d518e88b632067d2aeb5bbc5f819af7c1 /base | |
| parent | d233ff7eadb909914779089770dfb2e70f8beddf (diff) | |
| download | chromium_src-1283330e588bf1d5e73e7c2533af4c85e7cdc5a2.zip chromium_src-1283330e588bf1d5e73e7c2533af4c85e7cdc5a2.tar.gz chromium_src-1283330e588bf1d5e73e7c2533af4c85e7cdc5a2.tar.bz2 | |
Move SSLClientSocketNSS fallback logic to HttpNetworkTransaction.
In preparation for it to be shared with the OpenSSL logic once it reports
transport errors during handshaking.
This does result in a slight behavior change: if a handshake gives
ERR_CONNECTION_CLOSED, we now report that after the fallback chain ends (either
via TLS_FALLBACK_SCSV or hitting SSLv3). Before, we would always turn it into
ERR_SSL_PROTOCOL_ERROR. This is probably desirable and consistent with
Firefox's behavior. Add a test, FallbackSCSVClosed, to test this new behavior.
To that end, we should probably expect metrics to show some fraction of
ERR_SSL_PROTOCOL_ERROR turn into ERR_CONNECTION_CLOSED and
ERR_CONNECTION_RESET after this change.
BUG=372849
Review URL: https://codereview.chromium.org/353183005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280938 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
0 files changed, 0 insertions, 0 deletions