diff options
author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-22 19:33:27 +0000 |
---|---|---|
committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-22 19:33:27 +0000 |
commit | 5895ee10075b7ad9865817067ad85dcaa3ee0909 (patch) | |
tree | f8b908419ed9bbf348b3ab9675d99b385f332bfc /base | |
parent | 83870396b26c1ff73ba2eb8ff481cdf2a9c5f9c2 (diff) | |
download | chromium_src-5895ee10075b7ad9865817067ad85dcaa3ee0909.zip chromium_src-5895ee10075b7ad9865817067ad85dcaa3ee0909.tar.gz chromium_src-5895ee10075b7ad9865817067ad85dcaa3ee0909.tar.bz2 |
Fixed CID 102675, uninitialized member vars
CID=102675, 102638
TEST=none
Review URL: http://codereview.chromium.org/8965049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115579 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r-- | base/sync_socket.h | 1 | ||||
-rw-r--r-- | base/sync_socket_posix.cc | 4 | ||||
-rw-r--r-- | base/sync_socket_win.cc | 4 |
3 files changed, 5 insertions, 4 deletions
diff --git a/base/sync_socket.h b/base/sync_socket.h index 221e7b0..87b6a97 100644 --- a/base/sync_socket.h +++ b/base/sync_socket.h @@ -27,6 +27,7 @@ class BASE_EXPORT SyncSocket { #else typedef int Handle; #endif + static const Handle kInvalidHandle; // Creates a SyncSocket from a Handle. Used in transport. explicit SyncSocket(Handle handle) : handle_(handle) { } diff --git a/base/sync_socket_posix.cc b/base/sync_socket_posix.cc index f50d20b..c486cb5 100644 --- a/base/sync_socket_posix.cc +++ b/base/sync_socket_posix.cc @@ -26,10 +26,10 @@ namespace { // we clamp message lengths, which are size_t, to no more than INT_MAX. const size_t kMaxMessageLength = static_cast<size_t>(INT_MAX); -static const SyncSocket::Handle kInvalidHandle = -1; - } // namespace +const SyncSocket::Handle SyncSocket::kInvalidHandle = -1; + bool SyncSocket::CreatePair(SyncSocket* pair[2]) { Handle handles[2] = { kInvalidHandle, kInvalidHandle }; SyncSocket* tmp_sockets[2] = { NULL, NULL }; diff --git a/base/sync_socket_win.cc b/base/sync_socket_win.cc index 13091da..f69ba1c 100644 --- a/base/sync_socket_win.cc +++ b/base/sync_socket_win.cc @@ -28,10 +28,10 @@ const int kOutBufferSize = 4096; const int kInBufferSize = 4096; const int kDefaultTimeoutMilliSeconds = 1000; -static const SyncSocket::Handle kInvalidHandle = INVALID_HANDLE_VALUE; - } // namespace +const SyncSocket::Handle SyncSocket::kInvalidHandle = INVALID_HANDLE_VALUE; + bool SyncSocket::CreatePair(SyncSocket* pair[2]) { Handle handles[2]; SyncSocket* tmp_sockets[2]; |