summaryrefslogtreecommitdiffstats
path: root/base
diff options
context:
space:
mode:
authorgab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-05 18:11:54 +0000
committergab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-05 18:11:54 +0000
commit7bcf2fc5b6f0824c81e34bd4728ca7895bb2bfc9 (patch)
tree48e8bebe51462d1554b33ffb4a17193b40e06731 /base
parente4103fd71491a49a859d329788dfbb3eebf5bf8d (diff)
downloadchromium_src-7bcf2fc5b6f0824c81e34bd4728ca7895bb2bfc9.zip
chromium_src-7bcf2fc5b6f0824c81e34bd4728ca7895bb2bfc9.tar.gz
chromium_src-7bcf2fc5b6f0824c81e34bd4728ca7895bb2bfc9.tar.bz2
Add DPLOGs to base::LaunchProcess() failures on Windows.
I have manually added logs here too many times already and I think it doesn't hurt to have them in the codebase permanently. R=willchan@chromium.org NOTRY=True BUG=None Review URL: https://chromiumcodereview.appspot.com/12453006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186200 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r--base/process_util_win.cc9
1 files changed, 7 insertions, 2 deletions
diff --git a/base/process_util_win.cc b/base/process_util_win.cc
index 2a47f13..2861d30 100644
--- a/base/process_util_win.cc
+++ b/base/process_util_win.cc
@@ -351,8 +351,10 @@ bool LaunchProcess(const string16& cmdline,
flags |= CREATE_UNICODE_ENVIRONMENT;
void* enviroment_block = NULL;
- if (!CreateEnvironmentBlock(&enviroment_block, options.as_user, FALSE))
+ if (!CreateEnvironmentBlock(&enviroment_block, options.as_user, FALSE)) {
+ DPLOG(ERROR);
return false;
+ }
BOOL launched =
CreateProcessAsUser(options.as_user, NULL,
@@ -361,13 +363,16 @@ bool LaunchProcess(const string16& cmdline,
enviroment_block, NULL, &startup_info,
process_info.Receive());
DestroyEnvironmentBlock(enviroment_block);
- if (!launched)
+ if (!launched) {
+ DPLOG(ERROR);
return false;
+ }
} else {
if (!CreateProcess(NULL,
const_cast<wchar_t*>(cmdline.c_str()), NULL, NULL,
options.inherit_handles, flags, NULL, NULL,
&startup_info, process_info.Receive())) {
+ DPLOG(ERROR);
return false;
}
}