diff options
| author | dmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-13 23:11:54 +0000 |
|---|---|---|
| committer | dmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-13 23:11:54 +0000 |
| commit | 8585fd865df3044b8215e4486698422562712e6c (patch) | |
| tree | f6f2b49818fac61ed3039dc9aa1402b9647c7fed /base | |
| parent | 5e8d27087b478de2d7136fa9016c4e178e19305e (diff) | |
| download | chromium_src-8585fd865df3044b8215e4486698422562712e6c.zip chromium_src-8585fd865df3044b8215e4486698422562712e6c.tar.gz chromium_src-8585fd865df3044b8215e4486698422562712e6c.tar.bz2 | |
Fix event dispatching for PPB_Messaging::PostMessage. I asked Adam about the "plugin.onmessage = function(x){...}" style vs the 'plugin.addEventListener' style, and it seems that we should prefer supporting the addEventListener style.
This breaks the ability to do "plugin.onmessage =" :-(. I expected dispatchEvent to do it for me, but it does not. To add that support (if desired), I could work on making dispatchEvent do it, or I could fake it out via the script in MessageChannel (Basically have the old path of invoking onmessage directly, plus the new dispatchEvent code).
Brett, please focus on PPAPI-specific stuff. Adam, please focus on my event code (especially message_channel.cc and the JavaScript in test_post_message.cc).
BUG=None
TEST=test_post_message.cc
Review URL: http://codereview.chromium.org/6901060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85348 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
0 files changed, 0 insertions, 0 deletions