summaryrefslogtreecommitdiffstats
path: root/base
diff options
context:
space:
mode:
authorjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-25 20:07:12 +0000
committerjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-25 20:07:12 +0000
commita15115f065277f846b305ea98a11066ae49d3f2d (patch)
tree8c000aed4ec588bcb04cd5d0a15cb0e3fdc450ed /base
parent4865b8aa75173d66312264ecd819727177040a48 (diff)
downloadchromium_src-a15115f065277f846b305ea98a11066ae49d3f2d.zip
chromium_src-a15115f065277f846b305ea98a11066ae49d3f2d.tar.gz
chromium_src-a15115f065277f846b305ea98a11066ae49d3f2d.tar.bz2
TTF: Re-enable to tests used only for manual testing. We still want coverage
from those tests. Mark StackTrace.OutputToStream as flaky. TBR=stuartmorgan BUG=32070 TEST=StackTrace.* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48183 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r--base/debug_util_unittest.cc14
1 files changed, 6 insertions, 8 deletions
diff --git a/base/debug_util_unittest.cc b/base/debug_util_unittest.cc
index 6f4577a..c3c9cdf 100644
--- a/base/debug_util_unittest.cc
+++ b/base/debug_util_unittest.cc
@@ -11,8 +11,8 @@
// Note: On Linux, this test currently only fully works on Debug builds.
// See comments in the #ifdef soup if you intend to change this.
-// TODO(jar): BUG: 32070: Test is disabled... should be enabled.
-TEST(StackTrace, DISABLED_OutputToStream) {
+// Flaky, crbug.com/32070.
+TEST(StackTrace, FLAKY_OutputToStream) {
StackTrace trace;
// Dump the trace into a string.
@@ -92,17 +92,15 @@ TEST(StackTrace, DISABLED_OutputToStream) {
#endif // define(OS_MACOSX)
}
-// The test is used for manual testing (i.e. see the raw output).
-// To run the test use the flags:
-// --gtest_filter='*DebugOutputToStream' --gtest_also_run_disabled_tests
-TEST(StackTrace, DISABLED_DebugOutputToStream) {
+// The test is used for manual testing, e.g., to see the raw output.
+TEST(StackTrace, DebugOutputToStream) {
StackTrace trace;
std::ostringstream os;
trace.OutputToStream(&os);
LOG(INFO) << os.str();
}
-// The test is used for manual testing. See the comment above.
-TEST(StackTrace, DISABLED_DebugPrintBacktrace) {
+// The test is used for manual testing, e.g., to see the raw output.
+TEST(StackTrace, DebugPrintBacktrace) {
StackTrace().PrintBacktrace();
}