diff options
author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-31 05:40:33 +0000 |
---|---|---|
committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-31 05:40:33 +0000 |
commit | ef4d0aed4a2702fbd6478b9903f745cc555d930f (patch) | |
tree | 90789a52b472f80c2a91cd02d87d99fd0dc17325 /base | |
parent | d6df2e3959cafedab1d19fce2e312e8b674c34e6 (diff) | |
download | chromium_src-ef4d0aed4a2702fbd6478b9903f745cc555d930f.zip chromium_src-ef4d0aed4a2702fbd6478b9903f745cc555d930f.tar.gz chromium_src-ef4d0aed4a2702fbd6478b9903f745cc555d930f.tar.bz2 |
Remove some histograms that have not provided benefit.
I added these to try to look at exit codes in crashes, but we didn't find
antyhing surprising. I'm now removing them.
r=nsylvain
Review URL: http://codereview.chromium.org/343053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30663 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r-- | base/process_util_win.cc | 28 |
1 files changed, 0 insertions, 28 deletions
diff --git a/base/process_util_win.cc b/base/process_util_win.cc index ea1df60..f6157db 100644 --- a/base/process_util_win.cc +++ b/base/process_util_win.cc @@ -363,34 +363,6 @@ bool DidProcessCrash(bool* child_exited, ProcessHandle handle) { } // All other exit codes indicate crashes. - - // TODO(jar): Remove histogramming code when UMA stats are consistent with - // other crash metrics. - // Histogram the low order 3 nibbles for UMA - const int kLeastValue = 0; - const int kMaxValue = 0xFFF; - const int kBucketCount = kMaxValue - kLeastValue + 1; - static LinearHistogram least_significant_histogram("ExitCodes.LSNibbles", - kLeastValue + 1, kMaxValue, kBucketCount); - least_significant_histogram.SetFlags(kUmaTargetedHistogramFlag | - LinearHistogram::kHexRangePrintingFlag); - least_significant_histogram.Add(exitcode & 0xFFF); - - // Histogram the high order 3 nibbles - static LinearHistogram most_significant_histogram("ExitCodes.MSNibbles", - kLeastValue + 1, kMaxValue, kBucketCount); - most_significant_histogram.SetFlags(kUmaTargetedHistogramFlag | - LinearHistogram::kHexRangePrintingFlag); - // Avoid passing in negative numbers by shifting data into low end of dword. - most_significant_histogram.Add((exitcode >> 20) & 0xFFF); - - // Histogram the middle order 2 nibbles - static LinearHistogram mid_significant_histogram("ExitCodes.MidNibbles", - 1, 0xFF, 0x100); - mid_significant_histogram.SetFlags(kUmaTargetedHistogramFlag | - LinearHistogram::kHexRangePrintingFlag); - mid_significant_histogram.Add((exitcode >> 12) & 0xFF); - return true; } |