diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-04 17:52:06 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-04 17:52:06 +0000 |
| commit | f8adef5c0b349f3dbb9fe84ca36b41b66663907c (patch) | |
| tree | ab60167fe1c3edf5147b2a4ad01036bf6da14784 /base | |
| parent | 80a086c59537a006c36c8433a011f0a76e8a84d4 (diff) | |
| download | chromium_src-f8adef5c0b349f3dbb9fe84ca36b41b66663907c.zip chromium_src-f8adef5c0b349f3dbb9fe84ca36b41b66663907c.tar.gz chromium_src-f8adef5c0b349f3dbb9fe84ca36b41b66663907c.tar.bz2 | |
linux: improve warnings when NSS/PR shutdowns fail
Make one into a LOG(INFO) since it's relatively harmless;
add comments on the other with a link to the bug.
BUG=4609,18410
Review URL: http://codereview.chromium.org/159836
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22394 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
| -rw-r--r-- | base/nss_init.cc | 17 |
1 files changed, 12 insertions, 5 deletions
diff --git a/base/nss_init.cc b/base/nss_init.cc index 15fad89..e25232c 100644 --- a/base/nss_init.cc +++ b/base/nss_init.cc @@ -131,15 +131,22 @@ class NSSInitSingleton { SSL_ClearSessionCache(); SECStatus status = NSS_Shutdown(); - if (status != SECSuccess) - LOG(ERROR) << "NSS_Shutdown failed, leak? See " - "http://code.google.com/p/chromium/issues/detail?id=4609"; + if (status != SECSuccess) { + // We LOG(INFO) because this failure is relatively harmless + // (leaking, but we're shutting down anyway). + LOG(INFO) << "NSS_Shutdown failed; see " + "http://code.google.com/p/chromium/issues/detail?id=4609"; + } PL_ArenaFinish(); PRStatus prstatus = PR_Cleanup(); - if (prstatus != PR_SUCCESS) - LOG(ERROR) << "PR_Cleanup failed?"; + if (prstatus != PR_SUCCESS) { + // We LOG(ERROR) here because this failure is bad: it indicates + // NSPR isn't initialized and cleaned up on the same thread. + LOG(ERROR) << "PR_Cleanup failed; see " + "http://code.google.com/p/chromium/issues/detail?id=18410"; + } } private: |