diff options
| author | jdonnelly <jdonnelly@chromium.org> | 2015-08-14 16:47:30 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-14 23:47:59 +0000 |
| commit | ff51160943ee86667cecda60eb284ad2fcf507ee (patch) | |
| tree | ca68d7c411979bb8ee46c432459d8e7cb4a465c1 /base | |
| parent | 5a2bf5bcca1a4bbbca765926ce6dc1712c8b8fcf (diff) | |
| download | chromium_src-ff51160943ee86667cecda60eb284ad2fcf507ee.zip chromium_src-ff51160943ee86667cecda60eb284ad2fcf507ee.tar.gz chromium_src-ff51160943ee86667cecda60eb284ad2fcf507ee.tar.bz2 | |
Update full-form autofill config to always query the field trial state.
This is necessary for correct metrics reporting. Also, add a comment to FindFullName in field_trial.h mentioning its role in metrics reporting.
BUG=504644
Review URL: https://codereview.chromium.org/1291073005
Cr-Commit-Position: refs/heads/master@{#343534}
Diffstat (limited to 'base')
| -rw-r--r-- | base/metrics/field_trial.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/base/metrics/field_trial.h b/base/metrics/field_trial.h index 26257ab..9352128 100644 --- a/base/metrics/field_trial.h +++ b/base/metrics/field_trial.h @@ -404,8 +404,10 @@ class BASE_EXPORT FieldTrialList { // FieldTrial::kNotFinalized if the trial does not exist. static int FindValue(const std::string& name); - // Returns the group name chosen for the named trial, or the - // empty string if the trial does not exist. + // Returns the group name chosen for the named trial, or the empty string if + // the trial does not exist. The first call of this function on a given field + // trial will mark it as active, so that its state will be reported with usage + // metrics, crashes, etc. static std::string FindFullName(const std::string& name); // Returns true if the named trial has been registered. |