summaryrefslogtreecommitdiffstats
path: root/breakpad/BUILD.gn
diff options
context:
space:
mode:
authorscottmg <scottmg@chromium.org>2014-09-10 14:09:40 -0700
committerCommit bot <commit-bot@chromium.org>2014-09-10 21:21:43 +0000
commite8d3adb185373b15d593855f623fb5e28ef7878c (patch)
tree82f5833a19181dc7e96ae0b10160f6080187ec51 /breakpad/BUILD.gn
parentce61972ab68cedc2ecba82bb7b8aa02ca9e6614f (diff)
downloadchromium_src-e8d3adb185373b15d593855f623fb5e28ef7878c.zip
chromium_src-e8d3adb185373b15d593855f623fb5e28ef7878c.tar.gz
chromium_src-e8d3adb185373b15d593855f623fb5e28ef7878c.tar.bz2
gn: make some warning flags match gyp more closely
This fixes differences in -Wno-unused-function and -Wno-unneeded-internal-declaration. It also changes the diff'ing script to accept -Wendif-labels -Wextra -Wsign-compare when in GN but not gyp, because they're more conservative. These mostly happen when GN declares a lib chromium_code, but gyp doesn't. Also, remove some defines from the dont_care, as I'm not sure that we don't care yet. And some minor tweaks to diff script output. R=brettw@chromium.org BUG=335824 Review URL: https://codereview.chromium.org/555343002 Cr-Commit-Position: refs/heads/master@{#294229}
Diffstat (limited to 'breakpad/BUILD.gn')
-rw-r--r--breakpad/BUILD.gn8
1 files changed, 8 insertions, 0 deletions
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index 899cfef..68eb059 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -145,6 +145,10 @@ if (current_toolchain == host_toolchain && !is_win) {
]
configs += [ ":tools_config" ]
+
+ # There are some warnings in this code.
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
}
}
@@ -478,6 +482,10 @@ if (is_linux) {
"src/third_party/linux/include",
".",
]
+
+ # There are some warnings in this code.
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
}
test("breakpad_unittests") {