diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-22 23:01:02 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-22 23:01:02 +0000 |
| commit | 8e97eb2d3e1870b15ba1084e3f6bfdda237efe20 (patch) | |
| tree | db9a2dfdd8019b534eba38cb3b1d88788f278db2 /breakpad/breakpad.gyp | |
| parent | 610d36a0b785f0dfdb6cfce635806ddd5252cb39 (diff) | |
| download | chromium_src-8e97eb2d3e1870b15ba1084e3f6bfdda237efe20.zip chromium_src-8e97eb2d3e1870b15ba1084e3f6bfdda237efe20.tar.gz chromium_src-8e97eb2d3e1870b15ba1084e3f6bfdda237efe20.tar.bz2 | |
Fixes a number of issues with ProcessSingletonLinux.
(1) Use nonblocking sockets. Blocking the IO thread is bad.
(2) Handle multiple SocketReaders.
(3) Stop leaking file descriptors in SocketReader. Old code used to stop watching the fds, but not close them.
(4) Handle partial reads and writes. SocketReader reads until the sender shuts down his side of the socket.
(5) Timeout readers after 5 seconds so they don't hang forever.
BUG=http://www.crbug.com/12343
TEST=Open a chrome instance. Check /proc/<pid>/fd/ to see how many descriptors there are. Run "chrome www.google.com" on the command line a bunch of times, which should create a bunch of tabs. Make sure you close all these new tabs that pop up.a Check /proc/<pid>/fd/ to see how many descriptors there are. There shouldn't be many more (although some of the new renderers that got created take awhile because they get cleaned up). Keep repeating, you should be at a steady state of file descriptors.
Review URL: http://codereview.chromium.org/112054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16811 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'breakpad/breakpad.gyp')
0 files changed, 0 insertions, 0 deletions