summaryrefslogtreecommitdiffstats
path: root/breakpad
diff options
context:
space:
mode:
authormark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-24 01:13:15 +0000
committermark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-24 01:13:15 +0000
commit472e58a7d65088f589fc4fc064641fb40f0b34ab (patch)
tree5425a422d140865b974bce57300624d55ae89b85 /breakpad
parent214b81d70ec2a3eb09e381f7f306c651affd918b (diff)
downloadchromium_src-472e58a7d65088f589fc4fc064641fb40f0b34ab.zip
chromium_src-472e58a7d65088f589fc4fc064641fb40f0b34ab.tar.gz
chromium_src-472e58a7d65088f589fc4fc064641fb40f0b34ab.tar.bz2
Temporarily remove STACK CFI lines from Breakpad dump_syms symbol files.
BUG=google-breakpad:443 TEST=Better-looking, more thorough stacks produced on the crash server Review URL: http://codereview.chromium.org/7714022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97967 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'breakpad')
-rw-r--r--breakpad/pending/src/common/module.cc5
1 files changed, 5 insertions, 0 deletions
diff --git a/breakpad/pending/src/common/module.cc b/breakpad/pending/src/common/module.cc
index 6b83021..3a80e63 100644
--- a/breakpad/pending/src/common/module.cc
+++ b/breakpad/pending/src/common/module.cc
@@ -253,6 +253,10 @@ bool Module::Write(std::ostream &stream) {
return ReportError();
}
+#if 0
+ // Bypass all of the "STACK CFI" stuff for the time being to work around
+ // http://code.google.com/p/google-breakpad/issues/detail?id=443.
+ // This should be fine as long as -fomit-frame-pointer is not in use.
// Write out 'STACK CFI INIT' and 'STACK CFI' records.
vector<StackFrameEntry *>::const_iterator frame_it;
for (frame_it = stack_frame_entries_.begin();
@@ -279,6 +283,7 @@ bool Module::Write(std::ostream &stream) {
stream << endl;
}
}
+#endif
return true;
}