diff options
| author | sammc <sammc@chromium.org> | 2015-07-01 18:25:00 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-02 01:25:35 +0000 |
| commit | 5648c8598f20bc9756a82cf90cee204db44ea269 (patch) | |
| tree | c64a9115d6d3dd5e79a6c92c4de1072ccd197316 /breakpad | |
| parent | 984fbc18b3c734abdef6a36f547f5eb99a2143d4 (diff) | |
| download | chromium_src-5648c8598f20bc9756a82cf90cee204db44ea269.zip chromium_src-5648c8598f20bc9756a82cf90cee204db44ea269.tar.gz chromium_src-5648c8598f20bc9756a82cf90cee204db44ea269.tar.bz2 | |
clang/win: Fix warnings to prepare for building without -Wno-reorder.
This changes constructor initializer list ordering to match field
declaration ordering, except for gtest and breakpad, where the warning
is disabled.
BUG=505304
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1210013007
Cr-Commit-Position: refs/heads/master@{#337152}
Diffstat (limited to 'breakpad')
| -rw-r--r-- | breakpad/BUILD.gn | 8 | ||||
| -rw-r--r-- | breakpad/breakpad_handler.gypi | 5 |
2 files changed, 13 insertions, 0 deletions
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn index 7a1828a..2ccab3a 100644 --- a/breakpad/BUILD.gn +++ b/breakpad/BUILD.gn @@ -771,6 +771,14 @@ if (is_win) { "src/common/windows/string_utils-inl.h", "src/google_breakpad/common/minidump_format.h", ] + config("breakpad_handler_warnings") { + if (is_clang) { + # See https://code.google.com/p/google-breakpad/issues/detail?id=658. + cflags = [ "-Wno-reorder" ] + } + } + + configs += [ ":breakpad_handler_warnings" ] } source_set("breakpad_sender") { diff --git a/breakpad/breakpad_handler.gypi b/breakpad/breakpad_handler.gypi index 34b448d..657e819 100644 --- a/breakpad/breakpad_handler.gypi +++ b/breakpad/breakpad_handler.gypi @@ -44,6 +44,11 @@ 'type': 'static_library', 'variables': { 'breakpad_handler_target': 1, + 'clang_warning_flags': [ + # See + # https://code.google.com/p/google-breakpad/issues/detail?id=658. + '-Wno-reorder', + ], }, # TODO(gregoryd): direct_dependent_settings should be shared with the # 64-bit target, but it doesn't work due to a bug in gyp |