diff options
| author | yfriedman@chromium.org <yfriedman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-14 20:57:23 +0000 |
|---|---|---|
| committer | yfriedman@chromium.org <yfriedman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-14 20:57:23 +0000 |
| commit | ba290ce9a12c21bcd575836c49f7e065467add18 (patch) | |
| tree | 44d880fc23f0c05675e25fc4f5c7a38be17a865a /build/android/PRESUBMIT.py | |
| parent | 7f4d26b8f1e65269bf95f8e9869dde4d07cd5850 (diff) | |
| download | chromium_src-ba290ce9a12c21bcd575836c49f7e065467add18.zip chromium_src-ba290ce9a12c21bcd575836c49f7e065467add18.tar.gz chromium_src-ba290ce9a12c21bcd575836c49f7e065467add18.tar.bz2 | |
Change findbugs modifications from presubmit error->warning
While we want to bring this list down, blocking commits in this manner
with false positives, is too limiting.
BUG=180981
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12825011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188189 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/android/PRESUBMIT.py')
| -rw-r--r-- | build/android/PRESUBMIT.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py index fceeec3..2751f4a 100644 --- a/build/android/PRESUBMIT.py +++ b/build/android/PRESUBMIT.py @@ -16,15 +16,15 @@ _DELETIONS_ONLY_FILES = ( def _CheckDeletionsOnlyFiles(input_api, output_api): """Check that a certain listed files only have deletions. """ - errors = [] + warnings = [] for f in input_api.AffectedFiles(): if f.LocalPath() in _DELETIONS_ONLY_FILES: if f.ChangedContents(): - errors.append(f.LocalPath()) + warnings.append(f.LocalPath()) results = [] - if errors: - results.append(output_api.PresubmitError( - 'Following files should only contain deletions.', errors)) + if warnings: + results.append(output_api.PresubmitPromptWarning( + 'Following files should only contain deletions.', warnings)) return results |