diff options
| author | sebmarchand@chromium.org <sebmarchand@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-18 13:10:04 +0000 |
|---|---|---|
| committer | sebmarchand@chromium.org <sebmarchand@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-18 13:10:04 +0000 |
| commit | 1967740925d1d3cd619d9a67bc8c27f9f99ff59c (patch) | |
| tree | ae725f64ccbe5e9fdd2dc5d24919dfffc2dc251d /build/common.gypi | |
| parent | 7b40b232cf7e7b8c3362ab388fd27123d3e57db9 (diff) | |
| download | chromium_src-1967740925d1d3cd619d9a67bc8c27f9f99ff59c.zip chromium_src-1967740925d1d3cd619d9a67bc8c27f9f99ff59c.tar.gz chromium_src-1967740925d1d3cd619d9a67bc8c27f9f99ff59c.tar.bz2 | |
Rename FORCE_DETERMINISTIC_BUILD to DONT_EMBED_BUILD_METADATA.
Strictly speaking this flag isn't here to force a deterministic build, it's here to help us to make sure that no build metadata ends up in the build artifacts to help us guarantee a deterministic build.
(See the discussion in https://codereview.chromium.org/324403006/ for more details)
FTR, Nico said he'll take care of getting rid of __DATE__ and __TIME__ so this
new define will not be necessary for that.
On the other hand we may have issues with absolute path in __FILE__ and whatever
unforeseen C++ issue. This would require #ifdef'ing them out. This is not
something devs would want to do normally so this flag is off by default.
Eventually we'll want to fix the build system to not have to hack __FILE__ out
by ensuring they are *always* relative paths but until then, this variable can
be used to make progress
R=maruel@chromium.org, thakis@chromium.org
TBR=brettw@chromium.org
BUG=314403
Review URL: https://codereview.chromium.org/330813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278053 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/build/common.gypi b/build/common.gypi index 2a0118b..5b15e70 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -271,11 +271,11 @@ # on compile-only bots). 'fastbuild%': 0, - # Set to 1 to force deterministic builds (this isn't working yet but this - # flag will help us to get there). See http://crbug.com/314403. - # TODO(sebmarchand): Update this comment once this flag guarantee a - # deterministic build. - 'force_deterministic_build%': 0, + # Set to 1 to not store any build metadata (this isn't working yet but + # this flag will help us to get there). See http://crbug.com/314403. + # TODO(sebmarchand): Update this comment once this flag guarantee that + # there's no build metadata in the build artifacts. + 'dont_embed_build_metadata%': 0, # Set to 1 to force Visual C++ to use legacy debug information format /Z7. # This is useful for parallel compilation tools which can't support /Zi. @@ -1026,7 +1026,7 @@ 'use_xi2_mt%':'<(use_xi2_mt)', 'image_loader_extension%': '<(image_loader_extension)', 'fastbuild%': '<(fastbuild)', - 'force_deterministic_build%': '<(force_deterministic_build)', + 'dont_embed_build_metadata%': '<(dont_embed_build_metadata)', 'win_z7%': '<(win_z7)', 'dcheck_always_on%': '<(dcheck_always_on)', 'tracing_like_official_build%': '<(tracing_like_official_build)', @@ -2579,11 +2579,11 @@ }], # clang!=1 ], }], # fastbuild!=0 - ['force_deterministic_build==1', { + ['dont_embed_build_metadata==1', { 'defines': [ - 'FORCE_DETERMINISTIC_BUILD', + 'DONT_EMBED_BUILD_METADATA', ], - }], # force_deterministic_build==1 + }], # dont_embed_build_metadata==1 ['dcheck_always_on!=0', { 'defines': ['DCHECK_ALWAYS_ON=1'], }], # dcheck_always_on!=0 |