diff options
| author | thakis <thakis@chromium.org> | 2016-03-07 18:15:16 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-08 02:17:50 +0000 |
| commit | bb9cf1d14cf9f859dfc153663a67573132fcd99f (patch) | |
| tree | 7b6b20db379b5beb4503aaab6a9f878d32ecb14b /build/common.gypi | |
| parent | 754398d3eda3fdcfc5e28096c20828e0a48ef5fb (diff) | |
| download | chromium_src-bb9cf1d14cf9f859dfc153663a67573132fcd99f.zip chromium_src-bb9cf1d14cf9f859dfc153663a67573132fcd99f.tar.gz chromium_src-bb9cf1d14cf9f859dfc153663a67573132fcd99f.tar.bz2 | |
Revert of Enable XFA-Forms for the PDFium plugin (patchset #1 id:1 of https://codereview.chromium.org/1761673002/ )
Reason for revert:
Fails to build with clang-cl with very very scary warnings:
In file included from ..\..\third_party\pdfium\xfa/src/fxfa/src/app/xfa_ffapp.h:15:
..\..\third_party\pdfium\xfa/src/fgas/include/fx_fnt.h(131,23) : error: first operand of this 'memcmp' call is a pointer to dynamic class '_FX_FONTSIGNATURE'; vtable pointer will be compared [-Werror,-Wdynamic-class-memaccess]
FXSYS_memcmp(&left.FontSignature, &right.FontSignature,
~~~~~~~~~~~~ ^
..\..\third_party\pdfium\xfa/src/fgas/include/fx_fnt.h(131,23) : note: explicitly cast the pointer to silence this warning
FXSYS_memcmp(&left.FontSignature, &right.FontSignature,
^
(void*)
Reverting for now.
Original issue's description:
> Enable XFA-Forms for the PDFium plugin.
>
> This is a change to gather stability, performance, and size
> data and will be rolled back by 2016-03-15.
>
> This is the gyp portion of the change; the GN variables
> controlling the same things currently reside in the pdfium
> product itsef.
>
> Committed: https://crrev.com/afa43e7fa9754cff9ceb6969c665830a79a84c5b
> Cr-Commit-Position: refs/heads/master@{#379622}
TBR=rpop@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1773043002
Cr-Commit-Position: refs/heads/master@{#379700}
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/build/common.gypi b/build/common.gypi index 8713010..e8042fe 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -892,15 +892,11 @@ 'chromium_win_pch%': 1 }], - # Whether PDF plugin is enabled, and which options it supports. + # Whether PDF plugin is enabled. ['OS=="android" or OS=="ios" or (embedded==1 and chromecast==0)', { 'enable_pdf%': 0, - 'pdf_enable_v8%': 0, - 'pdf_enable_xfa%': 0, }, { 'enable_pdf%': 1, - 'pdf_enable_v8%': 1, - 'pdf_enable_xfa%': 1, }], ['chromeos==1 or OS=="android" or OS=="ios" or desktop_linux==1', { @@ -1231,8 +1227,6 @@ 'order_text_section%': '<(order_text_section)', 'enable_extensions%': '<(enable_extensions)', 'enable_pdf%': '<(enable_pdf)', - 'pdf_enable_v8%': '<(pdf_enable_v8)', - 'pdf_enable_xfa%': '<(pdf_enable_xfa)', 'enable_plugin_installation%': '<(enable_plugin_installation)', 'enable_plugins%': '<(enable_plugins)', 'enable_session_service%': '<(enable_session_service)', |