diff options
| author | perezju <perezju@chromium.org> | 2014-10-02 03:05:53 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-02 10:06:08 +0000 |
| commit | 949b6e5050c7a2ee2a894799db19ec325ba911ef (patch) | |
| tree | 5e297988e3c267c7d550125e9576d1a05f4f75f8 /build/get_landmines.py | |
| parent | 86a0c99d060868dddfa4abaa42b990e03ac284d3 (diff) | |
| download | chromium_src-949b6e5050c7a2ee2a894799db19ec325ba911ef.zip chromium_src-949b6e5050c7a2ee2a894799db19ec325ba911ef.tar.gz chromium_src-949b6e5050c7a2ee2a894799db19ec325ba911ef.tar.bz2 | |
Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)
Reason for revert:
Fails to compile on several bots:
https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio
First error:
FAILED: cd ../../clank/native/framework; python <snip ...>
../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
import org.chromium.content.common.TopControlsState;
^
symbol: class TopControlsState
location: package org.chromium.content.common
Original issue's description:
> Use the new java_cpp_enum rule in content.
>
> This moves most of the generated Java enums under content/ to use the
> java_cpp_enum rule removing the need for keeping the enums in
> separate list files and the need for the .template files.
>
> BUG=405532, 351558
>
> Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> Cr-Commit-Position: refs/heads/master@{#297789}
TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558
Review URL: https://codereview.chromium.org/625543002
Cr-Commit-Position: refs/heads/master@{#297793}
Diffstat (limited to 'build/get_landmines.py')
| -rwxr-xr-x | build/get_landmines.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/build/get_landmines.py b/build/get_landmines.py index f15d8db..8fa5a3b 100755 --- a/build/get_landmines.py +++ b/build/get_landmines.py @@ -58,7 +58,6 @@ def print_landmines(): print 'ninja dependency cycle: crbug.com/408192' if platform() == 'android': print 'Clobber: To delete stale generated .java files.' - print 'Delete stale generated .java files again. crbug.com/349592' def main(): |