diff options
author | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-24 22:58:47 +0000 |
---|---|---|
committer | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-24 22:58:47 +0000 |
commit | ab31b8f682af3ef1019b9a9bb0dbc8063236f13c (patch) | |
tree | 5795b382a5fc8eaf95e1fb36a398892e53a0165d /build/install-chroot.sh | |
parent | 2c3b7580b590f96d12e332bcfe3ade421fb483a5 (diff) | |
download | chromium_src-ab31b8f682af3ef1019b9a9bb0dbc8063236f13c.zip chromium_src-ab31b8f682af3ef1019b9a9bb0dbc8063236f13c.tar.gz chromium_src-ab31b8f682af3ef1019b9a9bb0dbc8063236f13c.tar.bz2 |
O2D:
(1) De-couple the Layer abstraction from the implementations details of Texture, giving JavaScript more control over the scene:
- Create a Pattern class backed by Cairo's cairo_pattern_t types (which we were already using implicitly) to represent a particular pattern to paint on a layer (think of it like a brush in PhotoShop/GIMP). A Pattern can be created from either a Texture or a solid colour. This will later allow us to move the PaintBackground() method out in to JS-space.
- Axe the overloaded Layer scaling parameters (which were used to represent both the width/height of the Layer and the scaling applied to the Texture), and replace them with separate width/height parameters to describe the Layer dimensions and scale_x/scale_y parameters to describe the scaling applied to the Pattern.
(2) Code clean-up:
- Use properties instead of functions in the Layer class.
- Use double instead of float.
- Get rid of unnecessary inheritance of Layer from ParamObject.
- Get rid of many unnecessary #include directives in layer.h.
- Get rid of super-spammy log message in RendererCairo::Paint().
- Improve comments.
TEST=compiled and loaded on Linux in both GL mode and Cairo mode with simple test scenes
BUG=none
Review URL: http://codereview.chromium.org/5276006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67335 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/install-chroot.sh')
0 files changed, 0 insertions, 0 deletions