diff options
| author | phoglund <phoglund@chromium.org> | 2015-06-16 23:54:11 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-17 06:54:41 +0000 |
| commit | 1becf72a2d1b5eec4468cc950142b083e9b24fbe (patch) | |
| tree | fb270c11288a94d0841012fc83ba504a8219afbf /build/internal | |
| parent | e57454ef129eb71526b11572573d7090575079f3 (diff) | |
| download | chromium_src-1becf72a2d1b5eec4468cc950142b083e9b24fbe.zip chromium_src-1becf72a2d1b5eec4468cc950142b083e9b24fbe.tar.gz chromium_src-1becf72a2d1b5eec4468cc950142b083e9b24fbe.tar.bz2 | |
Revert of Sync Windows build flags between GYP and GN (patchset #4 id:60001 of https://codereview.chromium.org/1183613006/)
Reason for revert:
Speculative revert for Linux GN clobber compile failure:
FAILED: python ../../remoting/webapp/build-webapp.py ...
Traceback (most recent call last):
File "../../remoting/webapp/build-webapp.py", line 487, in <module>
sys.exit(main())
File "../../remoting/webapp/build-webapp.py", line 483, in main
return buildWebApp(**vars(args))
File "../../remoting/webapp/build-webapp.py", line 257, in buildWebApp
+ buildtype + ': ' + service_environment)
Exception: Invalid service_environment targeted for Release:
ninja: build stopped: subcommand failed.
Original issue's description:
> Sync Windows build flags between GYP and GN
>
> In GN, turn on omtimize:max for base targets on all platforms, not just Android (matches GYP).
>
> In GN, don't duplicate /Os twice, make standard optimize = /O1 (matches GYP). Don't specify redundant optimization flags that are included as part of /O1 or /O2 (doesn't match GYP flag-wise, but should match functionality-wise).
>
> In GN, add a min Windows version of XP to x86 architecture binaries (matches GYP).
>
> In GYP, remove /GT ("EnableFiberSafeOptimizations"). This flag is super old (pre-dates GYP) and was likely turned on because it has the word "optimization" in it. It was only specified in official builds. However, according to the docs, this is making optimizations fiber safe (i.e. slower, by not caching the TLS pointer), rather than enabling optimizations for fibers. We don't use fibers so this flag is unnecessary and may be making TLS access slightly slower.
>
> Committed: https://crrev.com/67021f4d70fe838a5d78133bc6d5b305dfd70d72
> Cr-Commit-Position: refs/heads/master@{#334742}
TBR=scottmg@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1185963004
Cr-Commit-Position: refs/heads/master@{#334782}
Diffstat (limited to 'build/internal')
| -rw-r--r-- | build/internal/release_impl_official.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/build/internal/release_impl_official.gypi b/build/internal/release_impl_official.gypi index 36d5d787..d0729a9 100644 --- a/build/internal/release_impl_official.gypi +++ b/build/internal/release_impl_official.gypi @@ -8,6 +8,7 @@ 'VCCLCompilerTool': { 'InlineFunctionExpansion': '2', 'EnableIntrinsicFunctions': 'true', + 'EnableFiberSafeOptimizations': 'true', 'OmitFramePointers': 'false', # The above is not sufficient (http://crbug.com/106711): it # simply eliminates an explicit "/Oy", but both /O2 and /Ox |