diff options
| author | sky <sky@chromium.org> | 2015-05-28 16:22:53 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-28 23:23:22 +0000 |
| commit | 7b851a20f13e24921fd62e80a8b31f28f4a1ad36 (patch) | |
| tree | 23b5c9d86c13e7329236c34e618b07a75daf76e1 /build/ios | |
| parent | 6c4a368e5df834d2995f295bd2c77cd95688d09d (diff) | |
| download | chromium_src-7b851a20f13e24921fd62e80a8b31f28f4a1ad36.zip chromium_src-7b851a20f13e24921fd62e80a8b31f28f4a1ad36.tar.gz chromium_src-7b851a20f13e24921fd62e80a8b31f28f4a1ad36.tar.bz2 | |
Makes ApplicationRunner delete the delegate before the app
To do otherwise means the delegate outlives the app, which is error
prone (I was hitting an asan error running apptests). Before this
patch the destruction order was:
1. app
2. messageloop
3. delegate
Between 2 and 3 we may pump events posted by the delegate, which is
problematic since the app has been deleted.
Now it's:
. delegate
. app
. messageloop
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1160643003
Cr-Commit-Position: refs/heads/master@{#331877}
Diffstat (limited to 'build/ios')
0 files changed, 0 insertions, 0 deletions