diff options
| author | maruel <maruel@chromium.org> | 2015-05-22 18:37:56 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-23 01:38:23 +0000 |
| commit | ed6da5c8c4695faeb54aa354f48616cfd8207f71 (patch) | |
| tree | 81a00b4bd7ba761ce6cb38245a8ad0a846ece4af /build/isolate.gypi | |
| parent | 8a487be921ac8677623ec2d2150dab9c7a9ef46f (diff) | |
| download | chromium_src-ed6da5c8c4695faeb54aa354f48616cfd8207f71.zip chromium_src-ed6da5c8c4695faeb54aa354f48616cfd8207f71.tar.gz chromium_src-ed6da5c8c4695faeb54aa354f48616cfd8207f71.tar.bz2 | |
Fix luci-go isolate support on OSX.
The --extra-variable FOO BAR format is not supported by the Go implementation.
Switch to --extra-variable FOO=BAR. Using the second form is only a problem when
the value has spaces and only on Windows and this case is OSX only.
TBR=vadimsh@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1152243003
Cr-Commit-Position: refs/heads/master@{#331218}
Diffstat (limited to 'build/isolate.gypi')
| -rw-r--r-- | build/isolate.gypi | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/build/isolate.gypi b/build/isolate.gypi index 10033da..092a4e4 100644 --- a/build/isolate.gypi +++ b/build/isolate.gypi @@ -106,10 +106,8 @@ 'conditions': [ # Note: When gyp merges lists, it appends them to the old value. ['OS=="mac"', { - # <(mac_product_name) can contain a space, so don't use FOO=<(FOO) - # form. 'action': [ - '--extra-variable', 'mac_product_name', '<(mac_product_name)', + '--extra-variable', 'mac_product_name=<(mac_product_name)', ], }], ["test_isolation_outdir!=''", { |