diff options
| author | glider <glider@chromium.org> | 2014-12-03 08:23:10 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-03 16:23:47 +0000 |
| commit | ec036d3de01dd6c809baad7558ffbb4986fa1822 (patch) | |
| tree | 388ab0e0aa4584853bbe016395cba5f78aa0e5b2 /build/sanitizers/sanitizer_options.cc | |
| parent | f9f47ed9fa575ddbb8b1b7d3ea6429a5dec342db (diff) | |
| download | chromium_src-ec036d3de01dd6c809baad7558ffbb4986fa1822.zip chromium_src-ec036d3de01dd6c809baad7558ffbb4986fa1822.tar.gz chromium_src-ec036d3de01dd6c809baad7558ffbb4986fa1822.tar.bz2 | |
Revert of Turn on stack use-after-return detection in non-official ASan builds. (patchset #5 id:70003 of https://codereview.chromium.org/760503002/)
Reason for revert:
This broke some layout tests, see http://crbug.com/438499
Original issue's description:
> Turn on stack use-after-return detection in non-official ASan builds.
>
> BUG=390117
> R=scherkus@chromium.org
> TBR=earthdok@chromium.org,thakis@chromium.org
>
> Committed: https://crrev.com/136dc0bf75f9be7ae86c336005279b6dde4dee46
> Cr-Commit-Position: refs/heads/master@{#306429}
TBR=earthdok@chromium.org,thakis@chromium.org,scherkus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=390117
Review URL: https://codereview.chromium.org/774483004
Cr-Commit-Position: refs/heads/master@{#306618}
Diffstat (limited to 'build/sanitizers/sanitizer_options.cc')
| -rw-r--r-- | build/sanitizers/sanitizer_options.cc | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/build/sanitizers/sanitizer_options.cc b/build/sanitizers/sanitizer_options.cc index a3b05c1..821ba48 100644 --- a/build/sanitizers/sanitizer_options.cc +++ b/build/sanitizers/sanitizer_options.cc @@ -49,8 +49,6 @@ void _sanitizer_options_link_helper() { } // fast_unwind_on_fatal=1 - use the fast (frame-pointer-based) stack unwinder // to print error reports. V8 doesn't generate debug info for the JIT code, // so the slow unwinder may not work properly. -// detect_stack_use_after_return=1 - use fake stack to delay the reuse of -// stack allocations and detect stack-use-after-return errors. #if defined(OS_LINUX) #if defined(GOOGLE_CHROME_BUILD) // Default AddressSanitizer options for the official build. These do not affect @@ -64,14 +62,13 @@ const char kAsanDefaultOptions[] = // Default AddressSanitizer options for buildbots and non-official builds. const char *kAsanDefaultOptions = "strict_memcmp=0 symbolize=false check_printf=1 use_sigaltstack=1 " - "detect_leaks=0 strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 " - "detect_stack_use_after_return=1 "; + "detect_leaks=0 strip_path_prefix=Release/../../ fast_unwind_on_fatal=1"; #endif // GOOGLE_CHROME_BUILD #elif defined(OS_MACOSX) const char *kAsanDefaultOptions = "strict_memcmp=0 replace_intrin=0 check_printf=1 use_sigaltstack=1 " - "strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "; + "strip_path_prefix=Release/../../ fast_unwind_on_fatal=1"; static const char kNaClDefaultOptions[] = "handle_segv=0"; static const char kNaClFlag[] = "--type=nacl-loader"; #endif // OS_LINUX |