diff options
| author | dpranke <dpranke@chromium.org> | 2015-07-27 17:55:23 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-28 00:56:41 +0000 |
| commit | 7ba63a918a644773af77dc657792d6440e8afbc1 (patch) | |
| tree | 8b21ae1630f8504c2c0fcbb7b65a961c68973c49 /build/toolchain/win | |
| parent | 7a0d32250eaedd102f90d8c7932c7f8be2355d16 (diff) | |
| download | chromium_src-7ba63a918a644773af77dc657792d6440e8afbc1.zip chromium_src-7ba63a918a644773af77dc657792d6440e8afbc1.tar.gz chromium_src-7ba63a918a644773af77dc657792d6440e8afbc1.tar.bz2 | |
Revert "Add precompiled headers to GN build for large targets."
This reverts commit 8f3218985dde74063ccc362da47803be163f3165.
It looks like this may have broken incremental builds on Win.
TBR=brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1256223003
Cr-Commit-Position: refs/heads/master@{#340620}
Diffstat (limited to 'build/toolchain/win')
| -rw-r--r-- | build/toolchain/win/BUILD.gn | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn index 1ac3623..454cdde 100644 --- a/build/toolchain/win/BUILD.gn +++ b/build/toolchain/win/BUILD.gn @@ -80,7 +80,9 @@ template("msvc_toolchain") { tool("cc") { rspfile = "{{output}}.rsp" - precompiled_header_type = "msvc" + + # TODO(brettw) enable this when GN support in the binary has been rolled. + #precompiled_header_type = "msvc" pdbname = "{{target_out_dir}}/{{target_output_name}}_c.pdb" command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname" depsformat = "msvc" @@ -93,7 +95,9 @@ template("msvc_toolchain") { tool("cxx") { rspfile = "{{output}}.rsp" - precompiled_header_type = "msvc" + + # TODO(brettw) enable this when GN support in the binary has been rolled. + #precompiled_header_type = "msvc" # The PDB name needs to be different between C and C++ compiled files. pdbname = "{{target_out_dir}}/{{target_output_name}}_cc.pdb" |