diff options
| author | thakis <thakis@chromium.org> | 2015-09-23 22:08:00 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-24 05:09:26 +0000 |
| commit | 7c3c949a348b5f6e47eea84f5d533918d816fba4 (patch) | |
| tree | bddffdae60858911c34c172ff461bc68a569d1ea /build/win | |
| parent | f430d70efae143cab0a2cbad8a1b2ff30a73650f (diff) | |
| download | chromium_src-7c3c949a348b5f6e47eea84f5d533918d816fba4.zip chromium_src-7c3c949a348b5f6e47eea84f5d533918d816fba4.tar.gz chromium_src-7c3c949a348b5f6e47eea84f5d533918d816fba4.tar.bz2 | |
win: Let reorder-imports.py fail if its invocation of swapimport.exe fails.
At first I didn't hook up the script correctly in the gn build. swapimport.exe
printed
ERROR:swapimport_app.cc(214)] Path does not exist: ../../chrome/initialexe\chrome.exe
but that didn't make the build fail -- instead, it silently left the old
chrome.exe (from prior builds) around. Make it so that swapimport.exe failing
makes the build fail.
BUG=505062, 512599
Review URL: https://codereview.chromium.org/1363243002
Cr-Commit-Position: refs/heads/master@{#350482}
Diffstat (limited to 'build/win')
| -rwxr-xr-x | build/win/reorder-imports.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/build/win/reorder-imports.py b/build/win/reorder-imports.py index 281668f..00a69d75 100755 --- a/build/win/reorder-imports.py +++ b/build/win/reorder-imports.py @@ -31,7 +31,7 @@ def reorder_imports(input_dir, output_dir, architecture): args.append('chrome_elf.dll'); - subprocess.call(args) + subprocess.check_call(args) for fname in glob.iglob(os.path.join(input_dir, 'chrome.exe.*')): shutil.copy(fname, os.path.join(output_dir, os.path.basename(fname))) |