Revert of Use SuppressFBWarnings to suppress findbugs warnings (patchset #12 id:290001 of https://codereview.chromium.org/793203002/)

Reason for revert:
This is consistently causing bot failures, starting with https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/72002

Original issue's description:
> Use SuppressFBWarnings to suppress findbugs warnings
>
> This has several benefits:
> Makes the warning obvious at the place of the problem
> Makes suppressing the warnings the same as suppressing compiler and lint warnings
> Makes supporting findbugs as part of the build easier
>
> TBR=rmcilroy, mef, boliu
>
> BUG=431826
>
> Committed: https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d
> Cr-Commit-Position: refs/heads/master@{#311402}

TBR=aurimas@chromium.org,newt@chromium.org,tedchoc@chromium.org,mef@chromium.org,rmcilroy@chromium.org,boliu@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=431826

Review URL: https://codereview.chromium.org/797403005

Cr-Commit-Position: refs/heads/master@{#311417}

2 files changed, 108 insertions, 1 deletions

diff --git a/build/android/findbugs_filter/findbugs_exclude.xml b/build/android/findbugs_filter/findbugs_exclude.xml
index f087511..0fff636 100644
--- a/build/android/findbugs_filter/findbugs_exclude.xml
+++ b/build/android/findbugs_filter/findbugs_exclude.xml
@@ -17,8 +17,29 @@ In particular, ~ at the start of a string means it's a regex.
   <Match>
     <Class name="~org\.chromium\..*\.Manifest(\$\w+)?" />
   </Match>
+  <!-- Ignore bugs in NativeLibraries.java (the auto-generation confuses findbugs). -->
+  <Match>
+    <Class name="~org\.chromium\.base\..*\.NativeLibraries.*?" />
+  </Match>
+  <!--
+  Ignore bugs in CleanupReferenceTest.java (redundant null check)
+  TODO(joth): Group all GC related tests and filter them out, since the null
+  check is necessary to make sure the nullification is flushed to memory.
+  -->
+  <Match>
+    <Class name="~org\.chromium\.content\..*\.CleanupReferenceTest.*?" />
+  </Match>
+  <!-- Ignore errors in JavaBridge due to reflection. -->
+  <Match>
+    <Class name="~.*\.JavaBridge.*"/>
+    <Bug code="UuF,UrF,UMAC" />
+  </Match>
+  <!-- "Struct" like classes expect to have unused public data members -->
+  <Match>
+    <Class name="~.*android_webview.*FileChooserParams"/>
+    <Bug code="UrF" />
+  </Match>
   <!-- Ignore "reliance on default String encoding" warnings, as we're not multi-platform -->
-
   <Bug pattern="DM_DEFAULT_ENCODING" />
   <!-- Ignore bugs that are often false-positives in test code -->
   <Match>
@@ -28,4 +49,68 @@ In particular, ~ at the start of a string means it's a regex.
       <Bug pattern="DM_GC" />
     </Or>
   </Match>
+  <!--
+  Ignore calls to System.exit() following errors during loading the native library.
+  There is no way to recover from such errors without restarting the application,
+  so System.exit() is the best solution.
+  -->
+  <Match>
+    <Class name="~org\.chromium\.chrome\..*\.ChromiumSyncAdapter.*" />
+    <Method name="run" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="~org\.chromium\.chrome\..*\.ChromiumSyncAdapter" />
+    <Method name="startBrowserProcessesSync" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="~org\.chromium\.chrome\..*\.ChromeShellActivity" />
+    <Method name="onCreate" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="~org\.chromium\.chrome\..*\.AccountsChangedReceiver.*" />
+    <Method name="run" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="~org\.chromium\.chrome\..*\.NotificationService" />
+    <Method name="dispatchIntentOnUIThread" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="org.chromium.chrome.browser.preferences.Preferences" />
+    <Method name="onCreate" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="~org\.chromium\.content\..*\.ChildProcessService.*" />
+    <Method name="run" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="~org\.chromium\..*ContentBrowserTestsActivity" />
+    <Method name="onCreate" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="~org\.chromium\..*ContentShellActivity" />
+    <Method name="onCreate" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
+    <Class name="~org\.chromium\.components\.gcm_driver\..*\.GCMDriver" />
+    <Method name="launchNativeThen" />
+    <Bug code="Dm" />
+  </Match>
+  <!--
+  Ignore write to static field in GCMDriver, as it's the cleanest way to mark
+  the singleton as null when the native counterpart is destroyed.
+  -->
+  <Match>
+    <Class name="~org\.chromium\.components\.gcm_driver\..*\.GCMDriver" />
+    <Method name="destroy" />
+    <Bug code="ST" />
+  </Match>
 </FindBugsFilter>
diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt
index 0112d12..d51b121 100644
--- a/build/android/findbugs_filter/findbugs_known_bugs.txt
+++ b/build/android/findbugs_filter/findbugs_known_bugs.txt
@@ -1,7 +1,29 @@
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeArrayCoercionTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeArrayTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeBasicsTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeChildFrameTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeCoercionTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeFieldsTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeReturnValuesTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeTestBase.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At PerfTraceEvent.java
 M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At SimpleSynchronizedMethod.java
 M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At SimpleSynchronizedStaticMethod.java
 M C CST: Shouldn't use synchronized(this), please narrow down the synchronization scope.  At SimpleSynchronizedThis.java
+M D DMI: Hard coded reference to an absolute pathname in org.chromium.android_webview.test.ArchiveTest.testAutoBadPath()  At ArchiveTest.java
+M D DMI: Hard coded reference to an absolute pathname in org.chromium.android_webview.test.ArchiveTest.testExplicitBadPath()  At ArchiveTest.java
+M D SF: Switch statement found in org.chromium.chrome.browser.ChromeBrowserProvider.insert(Uri, ContentValues) where one case falls through to the next case  At ChromeBrowserProvider.java
+M M UG: org.chromium.content.browser.JavaBridgeReturnValuesTest$TestObject.getBooleanValue() is unsynchronized, org.chromium.content.browser.JavaBridgeReturnValuesTest$TestObject.setBooleanValue(boolean) is synchronized  At JavaBridgeReturnValuesTest.java
+M M UG: org.chromium.content.browser.JavaBridgeReturnValuesTest$TestObject.getStringValue() is unsynchronized, org.chromium.content.browser.JavaBridgeReturnValuesTest$TestObject.setStringValue(String) is synchronized  At JavaBridgeReturnValuesTest.java
+M V EI2: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.setFavicon(byte[]) may expose internal representation by storing an externally mutable object into ChromeBrowserProvider$BookmarkNode.mFavicon  At ChromeBrowserProvider.java
+M V EI2: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.setThumbnail(byte[]) may expose internal representation by storing an externally mutable object into ChromeBrowserProvider$BookmarkNode.mThumbnail  At ChromeBrowserProvider.java
+M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.favicon() may expose internal representation by returning ChromeBrowserProvider$BookmarkNode.mFavicon  At ChromeBrowserProvider.java
+M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.thumbnail() may expose internal representation by returning ChromeBrowserProvider$BookmarkNode.mThumbnail  At ChromeBrowserProvider.java
+M M LI: Incorrect lazy initialization of static field org.chromium.chrome.browser.sync.ProfileSyncService.sSyncSetupManager in org.chromium.chrome.browser.sync.ProfileSyncService.get(Context)  At ProfileSyncService.java
 M M LI: Incorrect lazy initialization of static field org.chromium.chrome.browser.download.DownloadManagerService.sDownloadManagerService in org.chromium.chrome.browser.download.DownloadManagerService.getDownloadManagerService(Context)  At DownloadManagerService.java
+M V EI2: org.chromium.content_public.browser.LoadUrlParams.setPostData(byte[]) may expose internal representation by storing an externally mutable object into LoadUrlParams.mPostData  At LoadUrlParams.java
+M V EI: org.chromium.content_public.browser.LoadUrlParams.getPostData() may expose internal representation by returning LoadUrlParams.mPostData  At LoadUrlParams.java
+M V EI2: org.chromium.net.ChromiumUrlRequest.setUploadData(String, byte[]) may expose internal representation by storing an externally mutable object into ChromiumUrlRequest.mUploadData  At ChromiumUrlRequest.java
 M D UrF: Unread public/protected field: org.chromium.chrome.browser.document.PendingDocumentData.extraHeaders  At DocumentTabModelSelector.java
 M D UrF: Unread public/protected field: org.chromium.chrome.browser.document.PendingDocumentData.postData  At DocumentTabModelSelector.java
 M D UrF: Unread public/protected field: org.chromium.chrome.browser.document.PendingDocumentData.referrer  At DocumentTabModelSelector.java