diff options
| author | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-12 14:26:37 +0000 |
|---|---|---|
| committer | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-12 14:26:37 +0000 |
| commit | 1d3bc326e1abb18ea92992c845cfef02b1621261 (patch) | |
| tree | f25d9735ded650c0aa0ce12580fb318eb76ebc80 /build | |
| parent | c135f3d6e4ce976d9277e091d823863782861b15 (diff) | |
| download | chromium_src-1d3bc326e1abb18ea92992c845cfef02b1621261.zip chromium_src-1d3bc326e1abb18ea92992c845cfef02b1621261.tar.gz chromium_src-1d3bc326e1abb18ea92992c845cfef02b1621261.tar.bz2 | |
Do not instrument globals when running ASan on Mac.
There is a subtle bug in the instrumentation of globals for ObjC
(https://code.google.com/p/address-sanitizer/issues/detail?id=171),
which manifests in random errors in tests on 10.8 (e.g. issue 196561)
BUG=196561
TBR=thakis
Review URL: https://codereview.chromium.org/14109004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193925 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi index 4785d8d..0967683 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -2978,6 +2978,13 @@ ], }], ], + 'conditions': [ + ['OS=="mac"', { + 'cflags': [ + '-mllvm -asan-globals=0', # http://crbug.com/196561 + ], + }], + ], }], ['tsan==1', { 'target_conditions': [ @@ -3599,6 +3606,7 @@ 'xcode_settings': { 'OTHER_CFLAGS': [ '-fsanitize=address', + '-mllvm -asan-globals=0', # http://crbug.com/196561 '-w', # http://crbug.com/162783 ], }, |