diff options
| author | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-06 21:24:02 +0000 |
|---|---|---|
| committer | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-06 21:24:02 +0000 |
| commit | 560e503e6d6f128eca0f4c3675428eaf0c1c7e7e (patch) | |
| tree | ef51f273d0d3df29df33b4e912b317cf3a0ecd91 /build | |
| parent | 234900cd8aca4d8327005e68f364e261253c4d0b (diff) | |
| download | chromium_src-560e503e6d6f128eca0f4c3675428eaf0c1c7e7e.zip chromium_src-560e503e6d6f128eca0f4c3675428eaf0c1c7e7e.tar.gz chromium_src-560e503e6d6f128eca0f4c3675428eaf0c1c7e7e.tar.bz2 | |
Adds a GYP flag for desktop notifications (enabled by default) and stub out relevant code if set to 0.
In chrome/browser/task_manager I moved notifications related code to their own files and allow exclusion and stubbing via GYP. Similarly I have added stubs for other parts including a chrome/browser/notifications/notification_stubs.cc which takes care of classes within that directory.
I also created some static methods in DesktopNotificationService to wrap commonly used notification related code so that we reduce the amount of stubs required.
BUG=none
TEST=existing notification tests succeed
Review URL: http://codereview.chromium.org/7053041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88040 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi index 6083fab..387cd78 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -437,6 +437,9 @@ # Point to ICU directory. 'icu_src_dir': '../third_party/icu', + # Enable desktop notifications. + 'enable_desktop_notifications%': 1, + 'conditions': [ ['os_posix==1 and OS!="mac"', { # This will set gcc_version to XY if you are running gcc X.Y.*. |