Use label name to generate PDB names in GN.

On Windows the GN toolchain setup used the output name to make unique PDB names. But the output name isn't necessarily that unique. The only requirement on that is that the outputs not collide, but multiple targets can otherwise have the same output name. Also, the output name can contain slashes that put it in different directories, or spaces which might confuse certain tools.

The label name is guaranteed to be unique in a given target_out_dir so this should give better names.

Review URL: https://codereview.chromium.org/1443733003

Cr-Commit-Position: refs/heads/master@{#359677}

1 files changed, 2 insertions, 2 deletions

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index 97dca96..e310039 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -67,7 +67,7 @@ template("msvc_toolchain") {
     tool("cc") {
       rspfile = "{{output}}.rsp"
       precompiled_header_type = "msvc"
-      pdbname = "{{target_out_dir}}/{{target_output_name}}_c.pdb"
+      pdbname = "{{target_out_dir}}/{{label_name}}_c.pdb"
       command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname"
       depsformat = "msvc"
       description = "CC {{output}}"
@@ -82,7 +82,7 @@ template("msvc_toolchain") {
       precompiled_header_type = "msvc"
 
       # The PDB name needs to be different between C and C++ compiled files.
-      pdbname = "{{target_out_dir}}/{{target_output_name}}_cc.pdb"
+      pdbname = "{{target_out_dir}}/{{label_name}}_cc.pdb"
       command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname"
       depsformat = "msvc"
       description = "CXX {{output}}"