diff options
| author | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-14 19:10:56 +0000 |
|---|---|---|
| committer | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-14 19:10:56 +0000 |
| commit | 794fb4784f694fe9d2dd23fa461caeb476c5a0de (patch) | |
| tree | 7034637073b683be7338ffeb6946ccd494846d50 /build | |
| parent | d3f692b3fc09b47fd8291179bd0394be8750a8b2 (diff) | |
| download | chromium_src-794fb4784f694fe9d2dd23fa461caeb476c5a0de.zip chromium_src-794fb4784f694fe9d2dd23fa461caeb476c5a0de.tar.gz chromium_src-794fb4784f694fe9d2dd23fa461caeb476c5a0de.tar.bz2 | |
Breakpad: Compile Breakpad into Chromium by default on Mac
This is intended to make it easier to test Breakpad crash dumping on
the buildbots. Crash dumping will be disabled in Chromium by default
at run time unless CHROME_HEADLESS is set.
The bots set CHROME_HEADLESS, but we don't really want the bots to be
uploading crash dumps that are useless without symbols, so uploading
is disabled except for official builds and when building with
mac_breakpad_uploads=1.
This should not affect stack backtraces that occur in tests (such as
browser_tests) via StackDumpSignalHandler(). Although Breakpad would
normally take priority over this signal handler, Breakpad does not get
enabled in these test suites because is_browser is false inside
InitCrashReporter().
This change leaves the Gyp option "mac_breakpad" for enabling the
creation of Breakpad files. This remains off by default for Chromium
builds, because the symbol dumping is slow and because it has problems
in the makefile-based Mac builds.
BUG=105778
TEST=run Chromium with --crash-test and CHROME_HEADLESS=1; a *.dmp file
should appear in ~/Library/Application Support/Chromium/Crash Reports
Review URL: http://codereview.chromium.org/8824003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114468 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/build/common.gypi b/build/common.gypi index 09f7b5d3..c59f931 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -725,6 +725,9 @@ ['OS=="mac"', { # Enable clang on mac by default! 'clang%': 1, + # Compile in Breakpad support by default so that it can be + # tested, even if it is not enabled by default at runtime. + 'mac_breakpad_compiled_in%': 1, 'conditions': [ # mac_product_name is set to the name of the .app bundle as it should # appear on disk. This duplicates data from @@ -737,13 +740,15 @@ 'mac_product_name%': 'Chromium', }], - # Feature variables for enabling Mac Breakpad and Keystone auto-update - # support. Both features are on by default in official builds with - # Chrome branding. ['branding=="Chrome" and buildtype=="Official"', { + # Enable uploading crash dumps. + 'mac_breakpad_uploads%': 1, + # Enable dumping symbols at build time for use by Mac Breakpad. 'mac_breakpad%': 1, + # Enable Keystone auto-update support. 'mac_keystone%': 1, }, { # else: branding!="Chrome" or buildtype!="Official" + 'mac_breakpad_uploads%': 0, 'mac_breakpad%': 0, 'mac_keystone%': 0, }], |