diff options
| author | mnaganov <mnaganov@chromium.org> | 2015-11-13 13:15:31 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-13 21:16:50 +0000 |
| commit | 8f1314f6d90ebcc24506cd036e76f98c3881e8ba (patch) | |
| tree | 600363fdb394d9272a044092cad8375a5080879f /build | |
| parent | 22241d9e94fbab2e6f111c8c994464ddc485b560 (diff) | |
| download | chromium_src-8f1314f6d90ebcc24506cd036e76f98c3881e8ba.zip chromium_src-8f1314f6d90ebcc24506cd036e76f98c3881e8ba.tar.gz chromium_src-8f1314f6d90ebcc24506cd036e76f98c3881e8ba.tar.bz2 | |
[Android WebView] Fire onPageFinished from WebContentsObserver::didStopLoading
After CL https://codereview.chromium.org/1381003004,
WebContentsObserver::didStopLoading has become the last event fired
when loading is finished.
WebView was using WebContentsObserver::didFinishLoad event
when it is fired for the main frame, but this callback now happens
before WebContentsImpl has updated its internal state. This causes
subtle race issues, e.g. unwanted reloading of the currently
loading page due to UA string update, which caused flakiness of
AwSettingsTest#testUserAgentStringOverrideForHistory test.
However, as didStopLoading is fired in some cases when didFinishLoad
isn't, we still need to use didFinishLoad to gate posting of
onPageFinishedEvent.
BUG=553762
Review URL: https://codereview.chromium.org/1432083004
Cr-Commit-Position: refs/heads/master@{#359642}
Diffstat (limited to 'build')
0 files changed, 0 insertions, 0 deletions